Skip to content

Document false positives when using Embed Pck on Windows#4600

Merged
Calinou merged 1 commit intogodotengine:masterfrom
Calinou:embed-pck-windows-antivirus
Mar 3, 2021
Merged

Document false positives when using Embed Pck on Windows#4600
Calinou merged 1 commit intogodotengine:masterfrom
Calinou:embed-pck-windows-antivirus

Conversation

@Calinou
Copy link
Copy Markdown
Member

@Calinou Calinou commented Jan 30, 2021

Comment on lines +22 to +24
antivirus programs. Therefore, it's recommended to avoid using it unless
you're distributing your project via Steam as it bypasses code signing and
antivirus checks.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind explaining why this should be the case? I see no reason why using Steam would bypass any AV checks let alone PE signature checks.

Copy link
Copy Markdown
Member Author

@Calinou Calinou Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steam was always given a free pass over code signing on Windows and macOS. This happens because Steam doesn't set the typical "downloaded" flag that web browsers do when it downloads games.

It's kind of like magic, I can't really explain why but it works.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's a specialty of Windows, that is does not enforce a binary to have a valid authenticode signature and just happily runs it even with invalid one (unless you have properly configured AppLocker or your PC is in an enterprise environment, where this is usualy enforced by group policies).

Anyway, this has nothing to do with any antivirus checks. Generally speaking, an AV will check every newly created/spawned/dropped executable no matter its digital signature and using Steam won't prevent false positive in this case. Only that specific AV vendor in the original issue could possibly remove a badly crafted detection.

If it was up to me, I'd just mention that: "On Windows, PCK embedding is also known to cause false positives in some antivirus programs."

@Calinou Calinou merged commit 4750d30 into godotengine:master Mar 3, 2021
@Calinou Calinou deleted the embed-pck-windows-antivirus branch March 3, 2021 22:25
@Calinou
Copy link
Copy Markdown
Member Author

Calinou commented Mar 3, 2021

Cherry-picked to the 3.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A Windows build of my game was identified as a virus

2 participants