ColorPicker: Allow other color wheels in okhsl mode#99662
Merged
Repiteo merged 1 commit intoMar 11, 2025
Conversation
Member
|
I'm curious is this flexibility exposed in the UI? |
Contributor
Author
|
@fire Yes, it's OK to use other color wheels to pick color and adjust it with the okhsl slider. |
Contributor
There's no reason to force a picker shape for OKHSL sliders. |
Member
|
Needs a rebase. |
remove `get_shape_override` in ColorMode
93a2ee7 to
67c2115
Compare
KoBeWi
approved these changes
Feb 9, 2025
fire
approved these changes
Feb 9, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
get_shape_overridemethod in ColorMode.Since #99461, there is no reason to disable other color wheels in okhsl mode. This makes the use of color wheels more flexible.
Closes #102598