ColorPicker: Fix OKHSL circle in HSV mode#99461
Merged
Merged
Conversation
2f2bbb9 to
e101311
Compare
Calinou
approved these changes
Nov 20, 2024
Calinou
left a comment
Member
There was a problem hiding this comment.
Tested locally, it works as expected.
fire
approved these changes
Nov 20, 2024
Contributor
Author
|
In addition to fixing the issue, I think it should be allowed to use other color wheels in okhsl mode, not just okhsl circle. If possible I would like to update this PR, or I will open a new PR after this merges. |
Member
|
Please add the modes in a separate pr! 👍 |
e101311 to
d6170f3
Compare
d6170f3 to
f6751d8
Compare
Member
|
#99515 should make it easier to add new shapes. |
Contributor
Author
|
Actually in my test, after this pr, we just need to remove the Of course, the refactoring is great and necessary. |
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68286.
OKHSL and HSV are different things, they should be stored separately in different fields.