Fix updating lightmap captures on Mobile#99367
Merged
Merged
Conversation
9 tasks
Contributor
|
Updated my MRP to this PR: This PR Indeed fixes the issues for the Mobile Renderer, thanks! Mobile_Probes.mp4 |
Calinou
approved these changes
Nov 17, 2024
Calinou
left a comment
Member
There was a problem hiding this comment.
Tested locally, it works as expected.
Calinou
reviewed
Nov 17, 2024
Comment on lines
+2068
to
+2070
| if (p_render_list == RENDER_LIST_OPAQUE && lightmap_captures_used) { | ||
| RD::get_singleton()->buffer_update(scene_state.lightmap_capture_buffer, 0, sizeof(LightmapCaptureData) * lightmap_captures_used, scene_state.lightmap_captures); | ||
| } |
Member
There was a problem hiding this comment.
Note that despite this being done in the opaque render list, it works on dynamic objects that have transparent materials too.
clayjohn
approved these changes
Nov 17, 2024
clayjohn
left a comment
Member
There was a problem hiding this comment.
Looks great!
These fixes always make me laugh when I run into them. You prepare yourself to do a deep dive into figuring out how a system works and what needs to change and then you realize that its literally just one forgotten line of code
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84846
"The best solution is usually the easiest one"
The mobile backend would only create the probe buffer, but never update it (unlike Forward)