Fix compatibility shadow size not being initialized#83141
Merged
Conversation
| directional_shadow.size = GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/size"); | ||
| directional_shadow.use_16_bits = GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/16_bits"); | ||
|
|
||
| // lightmap_probe_capture_update_speed = GLOBAL_GET("rendering/lightmapping/probe_capture/update_speed"); |
Member
There was a problem hiding this comment.
Suggested change
| // lightmap_probe_capture_update_speed = GLOBAL_GET("rendering/lightmapping/probe_capture/update_speed"); | |
| //lightmap_probe_capture_update_speed = GLOBAL_GET("rendering/lightmapping/probe_capture/update_speed"); |
Commented out code has no space
Contributor
Author
There was a problem hiding this comment.
No space ? I hate no space :P
Member
There was a problem hiding this comment.
(but yes commented out code has no leading space but text does, for clarity)
BastiaanOlij
commented
Oct 11, 2023
| directional_shadow.size = GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/size"); | ||
| directional_shadow.use_16_bits = GLOBAL_GET("rendering/lights_and_shadows/directional_shadow/16_bits"); | ||
|
|
||
| // lightmap_probe_capture_update_speed = GLOBAL_GET("rendering/lightmapping/probe_capture/update_speed"); |
Contributor
Author
There was a problem hiding this comment.
I added this as a comment so we don't overlook this once we make the lightmapper work.
Member
|
Likely fixes #82503 too? |
Contributor
Author
That would seem logical |
Member
Tested and confirmed. |
akien-mga
approved these changes
Oct 11, 2023
clayjohn
approved these changes
Oct 11, 2023
clayjohn
left a comment
Member
There was a problem hiding this comment.
Aahhhh this is an embarrassing mistake.
Looks good
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took me way too long to find but turned out that in a runtime build, we were never initialising our size for our directional shadow maps in the compatibility renderer, only the RD renderer.
In an editor build this was getting loaded through
EditorNode::_update_from_settingsso the issue was kind of hidden.