Use proper indices for lights, decals, and reflection probes in mobile scene shader#70929
Merged
Conversation
akien-mga
approved these changes
Jan 4, 2023
akien-mga
left a comment
Member
There was a problem hiding this comment.
Wouldn't this warrant an explanatory comment to make the magic value explcit?
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #70280
Fixes: #70231
Because the logic in these loops reads from
***_indicesbefore incrementing, we are incrementing for the next iteration not the current iteration. So we need to move to our second***_indicesvariable during the 4th iteration not during the 5thBy incrementing in the 4th iteration, we were always reading from the 0th index on the 5th iteration which often contains a thing (decal, probe, or light) that shouldn't be visible from this mesh.