Ensure that rim lighting uses an exponent base greater than zero#69985
Merged
Conversation
akien-mga
approved these changes
Dec 12, 2022
akien-mga
left a comment
Member
There was a problem hiding this comment.
Looks good. May warrant a short comment like // Epsilon min to prevent pow(0, 0) singularity. for future readers.
This avoids the undefined behavior that happens if the base is zero and the exponent is zero
Member
Author
Done! :) |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #69908
This avoids the undefined behavior that happens if the base is zero and the exponent is zero
See https://registry.khronos.org/OpenGL-Refpages/gl4/html/pow.xhtml
Alternatively we could ensure the exponent is always greater than 0, but that would essentially be a change to the roughness of the material and would change the rim to be the same as if the roughness was less than 1. This change ensures the smallest visual difference.
Before:
After:
