[macOS] Hack to force window activation for non-bundled app.#17187
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Mar 3, 2018
Merged
[macOS] Hack to force window activation for non-bundled app.#17187akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Member
|
0_o Note to self for cherry-picking. Wait to see if anyone complains about this. I have no doubt that this hack works @bruvzg but I truly don't understand it :) and I have no way to test it. This probably should go into 3.0.z though. |
Member
|
If it works, that's fine by me. @bruvzg Could you add some comments in the code to explain why this hack is needed though? |
cc96bed to
506e17e
Compare
Member
Author
|
Added some comments. AFAIK this is only way to fix unbundled apps focus on modern macOS (and unlike older hacks it's not using undocumented APIs), and it won't affect bundled apps at all. |
Member
|
Thanks! |
Contributor
|
Oh nice this is a great solution!!! |
Member
|
Cherrypicked into 3.0.3 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8653.