Fix shader compilation error when writing to FOG when render_mode fog_disabled#115026
Merged
Repiteo merged 1 commit intoJan 26, 2026
Conversation
…fog_disabled. Always declares FOG variable regardless of fog state. Previously, only declared fog if FOG_DISABLED was undefined. This caused errors if the code tried to write to fog later. Exists as a dummy variable when unused. Signed-off-by: Joshua Rothe <joshrothe@gmail.com>
FOG when render_mode fog_disabled
Contributor
|
Thanks! |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
…r-compilation-with-fog-disabled Fix shader compilation error when writing to `FOG` when `render_mode fog_disabled`
Contributor
|
Cherry-picked for 4.6.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fog_disabled.
Always declares FOG variable regardless of fog state. Previously, only declared fog if FOG_DISABLED was undefined. This caused errors if the code tried to write to fog later. Exists as a dummy variable when unused.
Fixes #94567.