SCons: Enable lightmapper and xatlas_unwrap modules on Android and iOS editors#107635
Conversation
…d iOS editors Fixes godotengine#94297. Fixes godotengine#107398.
clayjohn
left a comment
There was a problem hiding this comment.
Seems fine to me. I don't see any reason not to use these on the Android editor.
Funny enough we don't have an exception for the web editor where the lightmapper definitely won't work.
Yeah #103100 should solve that as |
syntaxerror247
left a comment
There was a problem hiding this comment.
Tested with MRP from linked issue, works as expected.
|
OMG I thought the unwrap worked fine and my geometry was just bad and since there’s 0 decent modeling free app, i couldn’t do anything(for when blender for phones and tablets). For what I tested seems to work well( s24 ultra), but will test when I have more time. |
|
It works very well, although it takes time. Why was it disabled for that long? |
From what i remember , because of mobile being prone to termal throttling really fast and not supporting compute as well as desktop. Godot can optimize the lightmap , but that still remains. |
|
Thanks! |
CC @migueldeicaza as you might want to test this on Xogot.
It seems like @Calinou already found this config discrepancy in #94297 (comment) and tested it together with @Saul2022 for the Android editor. But somehow it seems we forgot to PR the change.
Needs testing to confirm that both UV unwrapping and the lightmapper are functional on the Android editor (and Xogot, if Miguel or his team can test).