Disable Game Embedding in Single Window Mode#101936
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Jan 24, 2025
Merged
Disable Game Embedding in Single Window Mode#101936Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
bruvzg
approved these changes
Jan 23, 2025
Member
bruvzg
left a comment
There was a problem hiding this comment.
I do not think this can fully be fixed in single-window mode, so it seems reasonable to disable it.
Contributor
|
Thanks! |
Contributor
|
Can't you just display the game screen in the editor instead of on a separate window? I mean like display the game screen on subviewport in the editor. |
Contributor
Author
|
The separate window qas already disabled in Single window mode. The issues were when the game was inside the editor. Using a subviewport is another project already known to make it work in Single window mode and on Mac. |
Contributor
|
So you're going to make single window mode use subviewport in the future? |
Contributor
Author
|
Not me personnally because I don't have the knownlegde, but yes, it's the objective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables Game Embedding in Single Window Mode. It is currently not functioning well due to the inability to display popups or tooltips in front of the game window. On top of that, embedding mode is now the default.
While this is not a true fix for these issues, I do not have a better solution at the moment. At the very least, users will no longer need to disable embedding to run their games properly. A more suitable solution is required to correctly embed the game window in Single Window Mode.