Skip to content

in debug, include location information in error message on panic#926

Merged
Bromeon merged 3 commits intogodot-rust:masterfrom
0x53A:dev
Nov 5, 2024
Merged

in debug, include location information in error message on panic#926
Bromeon merged 3 commits intogodot-rust:masterfrom
0x53A:dev

Conversation

@0x53A
Copy link
Copy Markdown
Contributor

@0x53A 0x53A commented Oct 22, 2024

fixes #923

image

@Bromeon Bromeon added bug c: core Core components labels Oct 22, 2024
@GodotRust
Copy link
Copy Markdown

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-926

@0x53A
Copy link
Copy Markdown
Contributor Author

0x53A commented Oct 23, 2024

(I ran cargo fmt --all and rebased/force pushed)

@Bromeon Bromeon force-pushed the dev branch 2 times, most recently from bb1c53f to 3a45a54 Compare November 5, 2024 19:28
@Bromeon
Copy link
Copy Markdown
Member

Bromeon commented Nov 5, 2024

Thanks a lot!

Rebased onto master, and added a small trick to avoid tedious maintenance when the line number changes (which is very likely in that file). Also didn't want to create just another class in another file.

@Bromeon Bromeon added this pull request to the merge queue Nov 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
in debug, include location information in error message on panic
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@Bromeon Bromeon enabled auto-merge November 5, 2024 20:41
@Bromeon Bromeon added this pull request to the merge queue Nov 5, 2024
Merged via the queue into godot-rust:master with commit 3722014 Nov 5, 2024
@0x53A 0x53A deleted the dev branch November 7, 2024 02:22
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals and removed bug labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: core Core components quality-of-life No new functionality, but improves ergonomics/internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On panic in a godot-rust call, location information is thrown away and not shown

3 participants