chore: rac upgrade to 1.18.0 with new features for calendar and date pickers and playwright hanging issue#199
Conversation
…picker components
🦋 Changeset detectedLatest commit: 11544e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Bumps react-aria-components from ^1.17.0 to ^1.18.0 in @godaddy/antares and @bento/listbox to pick up new Calendar/DatePicker features, refreshes affected SSR snapshots (Checkbox, Radio, Modal — the latter due to embedded RadioGroup examples), and adds the previously-missing exports/Modal.ts subpath entry so Modal/ModalTrigger can be imported via the per-component subpath like other components.
Changes:
- Upgrade
react-aria-componentsto^1.18.0in both packages (and updatedpackage-lock.json). - Add
packages/@godaddy/antares/exports/Modal.tsto align with the existingexports/*subpath pattern. - Regenerate Checkbox/Radio/Modal SSR snapshots to match RAC 1.18's new per-input
aria-describedbyIDs.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/@godaddy/antares/package.json |
Bumps RAC to ^1.18.0. |
packages/@bento/listbox/package.json |
Bumps RAC to ^1.18.0. |
packages/@godaddy/antares/exports/Modal.ts |
Adds Modal subpath export to match other components. |
packages/@godaddy/antares/components/checkbox/test/__snapshots__/checkbox.node.test.tsx.snap |
Refreshes Checkbox SSR snapshots for new per-checkbox aria-describedby IDs. |
packages/@godaddy/antares/components/radio/test/__snapshots__/radio.node.test.tsx.snap |
Refreshes RadioGroup SSR snapshots for new per-radio aria-describedby IDs. |
packages/@godaddy/antares/components/modal/test/__snapshots__/modal.node.test.tsx.snap |
Updates Modal SSR snapshots for embedded RadioGroup ID changes. |
package-lock.json |
Resolves RAC 1.18.0 (with nested react-aria@3.49.0 / react-stately@3.47.0) and incidental peer flag churn. |
.changeset/wet-beans-serve.md |
Adds patch changeset entry for the upgrade. |
📚 Storybook PreviewPreview URL: https://godaddy.github.io/antares/pr-199-storybook/ Preview will be automatically deleted when this PR is closed. |
Docs Site PreviewPreview URL: https://godaddy.github.io/antares/pr-199-site/ Preview will be automatically deleted when this PR is closed. |
b9beae5 to
2a5a236
Compare
2a5a236 to
46f63c0
Compare
Bumping react aria components to latest 1.18.0 with new features for Calendar, Date Picker components, necessary for our Date and calendar components. It also brings new updates for Checkbox and Radio hence the snapshot updates.
Also,
npm run lintbefore tests for faster feedback on failures (tests take longer)