Skip to content

#796 - Fix Mac installers.#943

Merged
jyotisingh merged 2 commits intogocd:masterfrom
arvindsv:796_fix_mac_installers
Apr 3, 2015
Merged

#796 - Fix Mac installers.#943
jyotisingh merged 2 commits intogocd:masterfrom
arvindsv:796_fix_mac_installers

Conversation

@arvindsv
Copy link
Member

Details:

  • Don't have code inside their top-level .app directory. So, Apple Gatekeeper
    does not deem it an invalid app that should be trashed.
  • Allow environment variables like PATH to be overridden (Mac Agent has an incorrect PATH variable values. #852).
    Use as: PATH=/my/path open "Go Server.app"
  • Can set environment variables during startup (like in /etc/default/go-server
    on Linux). This is in ~/Library/Application Support/Go Agent/overrides.env
    and ~/Library/Application Support/Go Server/overrides.env.
  • Logging is corrected (Plugin log does not get created on mac #120)
  • They use ~/Library/Application Support/Go Agent and Go Server as their working
    directories.
  • Works with Apple and Oracle Java, 6 and 7.
  • They give a meaningful message, if Java cannot be found.

This fixes #796, fixes #120 and fixes #852.

Details:

* Don't have code inside their top-level .app directory. So, Apple Gatekeeper
  does not deem it an invalid app that should be trashed.

* Allow environment variables like PATH to be overridden (gocd#852).
  Use as: PATH=/my/path open "Go Server.app"

* Can set environment variables during startup (like in /etc/default/go-server
  on Linux). This is in ~/Library/Application Support/Go Agent/overrides.env
  and ~/Library/Application Support/Go Server/overrides.env.

* Logging is corrected (gocd#120)

* They use ~/Library/Application Support/Go Agent and Go Server as their working
  directories.

* Works with Apple and Oracle Java, 6 and 7.
@kmugrage
Copy link
Contributor

Verified these work on my personal Mac - didn't try to override any variables.

Kens-MacBook-Pro:~ kenmugrage$ uname -a
Darwin Kens-MacBook-Pro.local 14.1.0 Darwin Kernel Version 14.1.0: Mon Dec 22 23:10:38 PST 2014; root:xnu-2782.10.722/RELEASE_X86_64 x86_64
Kens-MacBook-Pro:
kenmugrage$ java -version
java version "1.7.0_75"
Java(TM) SE Runtime Environment (build 1.7.0_75-b13)
Java HotSpot(TM) 64-Bit Server VM (build 24.75-b04, mixed mode)

arvindsv added a commit to arvindsv/documentation that referenced this pull request Mar 24, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files movement to config directory was done as a part of a bug fix(Old tracker #5985 - not able to take backup because backup never complete in macosx). Since you have removed moveFilesFromGoServerDirToConfigDir method, one cannot upgrade from Go (pre-12.2) to 15.x or later directly. They need to upgrade to a version between 12.2 and 14.4 first, and then to 15.1. This needs to be documented.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no one is (strike that, I mean, should be) using 12.2 (in "prod" on Mac) and considering an upgrade to 15.1. I hope no one is. I don't think we should spend time documenting that, unless someone does hit the issue. 12.2 is over three years old. Let me know, if you think that's ok. If not, I'll document it.

I feel we have too many of those in documentation ("Prior to 12.3.1, Go server stored its data in /Library/Application Support/Go Server. From 12.3.1, it will be in < user-home >/Library/Application Support/Go Server.") and it gets confusing.

jyotisingh added a commit that referenced this pull request Apr 3, 2015
@jyotisingh jyotisingh merged commit b6a145f into gocd:master Apr 3, 2015
@arvindsv arvindsv deleted the 796_fix_mac_installers branch June 23, 2015 13:41
@ketan ketan modified the milestone: Old Milestone Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mac Agent has an incorrect PATH variable values. Mac installers - "Cannot be opened" message Plugin log does not get created on mac

5 participants