Thanks for PR. You should also look for the related JavaScript tests for this.

Updated the only test I could find related to search and opacity.

Marius, could you please fill out the form at http://www.go.cd/contribute/cla.html? Let me know if you have any questions.

Thanks

I've signed the CLA now, thanks for the heads up.

Marius

@ermauliks you are correct. I am amazed I could mess up on such a simple change.

@ciotlosm - did you get chance to fix this? Let me know if you need any help :-)

Isn't https://github.com/ciotlosm/gocd/commit/2f84d9980722f8835e72de22f4cfbdfbc0ada0a9 the commit for it?

@arvindsv I guess that the changes should be interchanged, i.e.

-$(targetElements).css('opacity', 1);
+$(targetElements).css('display', 'none');

should instead be

-$(targetElements).css('opacity', 1);
+$(targetElements).css('display', 'block');

at line 110 and the opposite at line 114.

@ermauliks - Please correct if my understanding is wrong.

@arvindsv Ok, I spoke too soon... Yes, you are right. The latest commit seems to have the changes.

@sachinsudheendra - looks alright now. Good to go with.

FEEDBACK : When there is no pipeline found with given name, should we show a message? E.g. "No pipeline found under this group with given texts." or something similar.

Hi guys, I was away for holiday. I've made the change right after feedback was received, but I didn't comment back (just closed and reopened the merge request with the changes done).
I totally agree with the feedback, however that would be much more complex to achieve as I couldn't get the vagrant image to work for me at the moment.

@ciotlosm I've migrated your changes to Rails4 as-well and I've have created a new PR - #576 . I'll be merging that and closing this PR without any action.