Using unique string for cipher generation#2045
Merged
ketan merged 1 commit intogocd:masterfrom Mar 11, 2016
Merged
Conversation
| } | ||
|
|
||
| private String reEncryptUsingNewKey(byte[] oldCipher, byte[] newCipher, String encryptedValue) throws InvalidCipherTextException { | ||
| GoCipher cipher = new GoCipher(); |
Member
There was a problem hiding this comment.
Can make this a field, if needed. Ok to leave it in too. I thought that every call to CipherProvider#primeKeyCache reads the cipher file. But, it is private static volatile. So, it doesn't.
4959ae6 to
c38b8cc
Compare
…d re-encryption of secure values in config when unsafe cipher is available
c38b8cc to
8608a2c
Compare
ketan
added a commit
that referenced
this pull request
Mar 11, 2016
Using unique string for cipher generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-generation of cipher and re-encryption of secure values in config when unsafe cipher is available.
This cipher is used for encryption of secure variables in Go's config