Adding verbosity to Exception message while loading DatabaseProvider.#203
Merged
arvindsv merged 1 commit intogocd:masterfrom May 22, 2014
Merged
Conversation
Actual exception wasn't being forwared in the new exception throw. This meant that inner exceptions were getting swallowed at this point and every error, either Class Load exception or Configuration exception were indicated by the same exception string. As a fix, passing along 'e' to the new exception.
arvindsv
added a commit
that referenced
this pull request
May 22, 2014
Adding verbosity to Exception message while loading DatabaseProvider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual exception wasn't being forwared in the new exception throw. This meant that inner exceptions were getting swallowed at this point and every error, either Class Load exception or Configuration exception were indicated by the same exception string. As a fix, passing along 'e' to the new exception.