Adding a layer for Database Connection Configurations#185
Merged
jyotisingh merged 4 commits intogocd:masterfrom May 15, 2014
Merged
Adding a layer for Database Connection Configurations#185jyotisingh merged 4 commits intogocd:masterfrom
jyotisingh merged 4 commits intogocd:masterfrom
Conversation
Adding a new layer for database configuration so that different providers can choose their way for managing database related configurations. For H2, this continues to follow the old way of getting the configuration from SystemEnvironment.
…n abstract class instead of interface.
Database port for H2 was fetched wrongly. Using systemEnvironment#getDatabaseSeverPort for getting the port value.
Contributor
Author
|
Personal build passes @ http://go02.thoughtworks.com:8153/go/tab/pipeline/history/personal-sachinsudheendra |
jyotisingh
added a commit
that referenced
this pull request
May 15, 2014
Adding a layer for Database Connection Configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of providing a definite way for database adapters to implement their configuration, I've externalised the H2 configuration in a way for other implementations to easily plug into the DB layer.