Throwing BadCredentialsException when user is not found in configured…#1740
Merged
zabil merged 2 commits intogocd:masterfrom Jan 5, 2016
Merged
Throwing BadCredentialsException when user is not found in configured…#1740zabil merged 2 commits intogocd:masterfrom
zabil merged 2 commits intogocd:masterfrom
Conversation
… ldap so an attacker would not be able to guess available logins on the ldap server
Contributor
There was a problem hiding this comment.
We must start using http://junit.org/apidocs/org/junit/rules/ExpectedException.html
For asserting exceptions.
zabil
added a commit
that referenced
this pull request
Jan 5, 2016
Throwing BadCredentialsException when user is not found in configured…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… ldap so a potential attacker would not be able to differentiate between non-existent user or a wrong password.