Skip to content

Apply command option from environment values#371

Merged
goccy merged 1 commit into
goccy:mainfrom
osamingo:apply-opts-from-env-values
Dec 10, 2024
Merged

Apply command option from environment values#371
goccy merged 1 commit into
goccy:mainfrom
osamingo:apply-opts-from-env-values

Conversation

@osamingo

@osamingo osamingo commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

What

  • Apply command option from environment values
  • If both are specified, long takes precedence (this depends on the behavior of jessevdk/go-flags and may be changed by this libs update)

Why

  • When we use GitHub Actions, we can't take arguments, so we need to pass the value in an environment variable

@goccy goccy merged commit 4676a5c into goccy:main Dec 10, 2024
@goccy

goccy commented Dec 10, 2024

Copy link
Copy Markdown
Owner

Thank you for your contribution !!! LGTM 👍

@osamingo osamingo deleted the apply-opts-from-env-values branch December 10, 2024 15:05
iolalla pushed a commit to iolalla/bigquery-emulator that referenced this pull request Aug 16, 2025
ohaibbq referenced this pull request in Recidiviz/bigquery-emulator Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants