Conversation
1 task
Member
Author
|
The Gobview CI failure in goblint/analyzer#1137 seems to suggest that it doesn't actually work for some reason. |
michael-schwarz
approved these changes
Sep 11, 2023
Member
Author
|
I cherry-picked parts of this to Also the jsoo aliases didn't seem to work although jsoo's own |
Member
Author
|
Replaced by #52. Somehow it seems that the unix stubs changes aren't required anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't checked whether Gobview actually works on OCaml 5.0 with these changes though.
On a side note, we really need to do #9 because jsoo-react 0.1 is now on opam, so we could avoid the pin and having to hack version bounds of some old jsoo-react fork ourselves.