If I remember correctly, I had the same issue with child components when I tried to update to the latest version of jsoo-react a few months ago. I think #8 should be fine for now. jsoo-react isn't stable yet anyway, so this probably won't be the last breaking change they make.

By the way, the also mentioned that there might be a compatibility library for this big breaking change at some point: ml-in-barcelona/jsoo-react#162 (comment).

I rebased Simmo's work on a more recent version of the master branch, removed the opam pin such that we should now be using the opam release of jsoo-react directly, fixed the above mentioned compilation error with the ErrorBoundary and the remaining compilation errors. So while it at least builds, there is this weird TypeError: c1 is undefined error when running GobView and so far I have not really an idea why. Also, I think there might be a syntactically nicer way of fixing the ErrorBoundary compilation error, but so far I have not found out how.

So while it at least builds, there is this weird TypeError: c1 is undefined error when running GobView and so far I have not really an idea why.

If you use the dev profile in dune-workspace to build, then js_of_ocaml should produce non-minimized JS that is somewhat more readable and has roughly original OCaml names for things.

@sim642 Since you worked on this initially, it might make sense if you review it. (I cannot request you as you are the one who started the PR.)

This seems to work fine with the dev profile, but with a non-dev profile (like trace), GobView breaks with an exception in the browser console:

Fatal error: exception Invalid_argument("Cilfacade.get_ikind: non-integer type void ")

Or maybe this profile issue exists already before this PR?

I discovered this warning before but was not able reconstruct it. If I remember correctly, it was due to get_ikind (indirectly) being used for the definition of a value. And I suspect that it depended on the compilation order whether this caused an error or not.

I checked that for me it also happens on master, so I opened #38 about it, so this isn't a blocker for this PR, but still needs a fix.

Nevermind, I somehow had pinned jsoo-react to the old one again I guess.

Somehow I'm now getting this error when building GobView:

File "gobview/src/dune", line 39, characters 2-53:
39 |   (pps gen_js_api.ppx js_of_ocaml-ppx jsoo-react.ppx)))
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fatal error: exception Invalid_argument("A spread as a DOM element's children don't make sense written together. You can simply remove the spread.")

So I guess there's some excessive ... although I'm not sure why this didn't come up before. It's also hard to debug because the error isn't at the right place.