Conversation
|
Strange, it seems it builds but the CI tests still fail for OCaml <5.0? (For debugging, the note on how to run a single test under dune from the README may be helpful here.) |
I have tried, but could not find a solution yet. Considering that older versions dont even build (due to dependencies) it might also make sense to drop domain_shims and keep this for an OCaml 5 Version in the future. |
By adapting test script to use domain_shims (like in 13fc020)
| string *) | ||
| (d: doc) = | ||
| let aligns: int list ref = ref [0] in (* A stack of alignment columns *) | ||
| let aligns: int list refDLS = refDLS [0] in (* A stack of alignment columns *) |
There was a problem hiding this comment.
I'm confused about this one. This is a local reference, but there's also a global one with the same name. How are these related?
By defining aligns locally, this function has no access to the global one, so it seems like this could be just a ref still. Or am I missing something?
| aligns := res :: !aligns; | ||
| res.deltaFromPrev := abscol - !topAlignAbsCol; | ||
| topAlignAbsCol := abscol | ||
| DLS.set aligns (res :: (DLS.get aligns)); |
There was a problem hiding this comment.
There's lots of unnecessary parentheses around DLS.get now all over this file.
CHANGES: * Add `_Float16` type support (goblint/cil#190, goblint/cil#193). * Add C23 `alignof` and `alignas` support (goblint/cil#189, goblint/cil#191). * Add initializer support for anonymous struct in union (goblint/cil#176, goblint/cil#184). * Fix enumerator printing (goblint/cil#185). * Remove global state from `Pretty` (goblint/cil#187). * Remove OCaml <4.12 support (goblint/cil#180, goblint/cil#181). * Use `gnu11` standard in most tests (goblint/cil#188, goblint/cil#192).
Replace references with DLS to enable multiple domains.