Implement ana.apron.invariant.diff-box directly in domain#1873
Merged
Implement ana.apron.invariant.diff-box directly in domain#1873
ana.apron.invariant.diff-box directly in domain#1873Conversation
This should be faster, because it doesn't require box domain analysis in parallel. The domain is converted to box and back only during invariant generation. It's also more precise in some sense because it can exclude box-like constraints, which cannot be inferred by box alone. But maybe that's also a downside because it can exclude constraints, which still need the more precise domain.
Member
Author
|
I did some sv-benchmarks 60s 1GB 1 core level01 verify-validate runs with:
Already using the old This makes less of a difference: 5719 → 5822, but it's a much nicer and cheaper implementation (although in the grand scheme of SV-COMP this doesn't show). |
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Nov 27, 2025
CHANGES: Functionally equivalent to Goblint in SV-COMP 2026. * Add sequential portfolio for SV-COMP (goblint/analyzer#1845, goblint/analyzer#1867, goblint/analyzer#1877). * Add struct bitfield support (goblint/analyzer#1739, goblint/analyzer#1823). * Improve bitwise operations for integer domains (goblint/analyzer#1739). * Reimplement HTML output in OCaml (goblint/analyzer#1752). * Remove YAML witness version 0.1 support (goblint/analyzer#1812, goblint/analyzer#1817, goblint/analyzer#1852, goblint/analyzer#1853, goblint/analyzer#1855). * Fix incorrect invariants in witnesses (goblint/analyzer#1818, goblint/analyzer#1876). * Simplify relational invariants in witnesses (goblint/analyzer#1826, goblint/analyzer#1871, goblint/analyzer#1873). * Fix argument types in Goblint stubs (goblint/analyzer#1684, goblint/analyzer#1814, goblint/analyzer#1779, goblint/analyzer#1820).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #1871.
This should be faster, because it doesn't require box domain analysis in parallel.
The domain is converted to box and back only during invariant generation.
It's also more precise in some sense because it can exclude box-like constraints, which cannot be inferred by box alone.
But maybe that's also a downside because it can exclude constraints, which still need the more precise domain.
So it's not clear to me what is the right thing. We could keep both, both that's one more configurable option which is unlikely to be useful.