Weaken Lattice.Lift{,2}Conf arguments, remove Lattice.LiftPO#1728
Merged
Weaken Lattice.Lift{,2}Conf arguments, remove Lattice.LiftPO#1728
Lattice.Lift{,2}Conf arguments, remove Lattice.LiftPO#1728Conversation
michael-schwarz
approved these changes
Apr 16, 2025
sim642
added a commit
that referenced
this pull request
Nov 7, 2025
These are unneeded since PR #1728.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lattice.LiftConfadds abotandtop, but its argument also required them without using them. Therefore, the sensible thing is to just weaken the argument signature.This allows us to just get rid of
Lattice.LiftPO, which was a copy ofLattice.LiftConfwith basically just this difference (and the handling ofUncomparable).The benefit of this weakening is that fewer dummy
topandbotimplementations are needed just to lift domains without top and bottom. We probably have a bunch around but they're not too easy to find immediately.This is on top of #1727.