Move Spec lifters out of Constraints#1575
Merged
michael-schwarz merged 18 commits intomasterfrom Sep 24, 2024
Merged
Conversation
| | Target (target_node, target_context) -> | ||
| let target_fundec = Node.find_fundec target_node in | ||
| if CilType.Fundec.equal target_fundec current_fundec && ControlSpecC.equal target_context (ctx.control_context ()) then ( | ||
| if M.tracing then Messages.tracel "longjmp" "Fun: Potentially from same context, side-effect to %a" Node.pretty target_node; |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: semgrep.trace-not-in-tracing
| (* Eval `env` again to avoid having to construct bespoke ctx to ask *) | ||
| let targets = path_ctx.ask (EvalJumpBuf env) in | ||
| let valid_targets = path_ctx.ask ValidLongJmp in | ||
| if M.tracing then Messages.tracel "longjmp" "Jumping to %a" JmpBufDomain.JmpBufSet.pretty targets; |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: semgrep.trace-not-in-tracing
| | Target (target_node, target_context) -> | ||
| let target_fundec = Node.find_fundec target_node in | ||
| if CilType.Fundec.equal target_fundec current_fundec && ControlSpecC.equal target_context (ctx.control_context ()) then ( | ||
| if M.tracing then Messages.tracel "longjmp" "Potentially from same context, side-effect to %a" Node.pretty target_node; |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: semgrep.trace-not-in-tracing
| ctx.sideg (V.longjmpto (target_node, ctx.context ())) (G.create_local (Lazy.force specialed)) | ||
| ) | ||
| else if JmpBufDomain.JmpBufSet.mem target valid_targets then ( | ||
| if M.tracing then Messages.tracel "longjmp" "Longjmp to somewhere else, side-effect to %i" (S.C.hash (ctx.context ())); |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: semgrep.trace-not-in-tracing
Member
|
Nice! I think this is a really good step towards making modules shorter and easier to follow! |
michael-schwarz
approved these changes
Sep 24, 2024
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Nov 28, 2024
CHANGES: Functionally equivalent to Goblint in SV-COMP 2025. * Add 32bit vs 64bit architecture support (goblint/analyzer#54, goblint/analyzer#1574). * Add per-function context gas analysis (goblint/analyzer#1569, goblint/analyzer#1570, goblint/analyzer#1598). * Adapt automatic static loop unrolling (goblint/analyzer#1516, goblint/analyzer#1582, goblint/analyzer#1583, goblint/analyzer#1584, goblint/analyzer#1590, goblint/analyzer#1595, goblint/analyzer#1599). * Adapt automatic configuration tuning (goblint/analyzer#1450, goblint/analyzer#1612, goblint/analyzer#1181, goblint/analyzer#1604). * Simplify non-relational integer invariants in witnesses (goblint/analyzer#1517). * Fix excessive hash collisions (goblint/analyzer#1594, goblint/analyzer#1602). * Clean up various code (goblint/analyzer#1095, goblint/analyzer#1523, goblint/analyzer#1554, goblint/analyzer#1575, goblint/analyzer#1588, goblint/analyzer#1597, goblint/analyzer#1614).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are moved to a new
liftersdirectory.The splitting is done such that
git blamehistory is preserved for default git settings. Thus the git graph is a bit of a braid.