Introduce sync reason JoinCall & Limit sync at function start nodes#1508
Merged
michael-schwarz merged 4 commits intomasterfrom Jun 13, 2024
Merged
Introduce sync reason JoinCall & Limit sync at function start nodes#1508michael-schwarz merged 4 commits intomasterfrom
JoinCall & Limit sync at function start nodes#1508michael-schwarz merged 4 commits intomasterfrom
Conversation
Helps avoid "sync" calls for function start nodes when threadflag is context-sensitive. Previsouly, it was only avoided when the flag was path-sensitive
CallJoin & Limit sync at function start nodes
CallJoin & Limit sync at function start nodesJoinCall & Limit sync at function start nodes
sim642
reviewed
Jun 13, 2024
7 tasks
sim642
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps avoid "sync" calls for function start nodes when threadflag is context-sensitive. Previously, it was only avoided when the flag was path-sensitive (c.f. #1475).
This has some immediate termination advantages, and can potentially also boost precision.
TODO:
threadflagis path-sensitive but not context-sensitive? (It seems sound, but this notion may require re-thinking in general Reconsider notion of path-sensitive but context-insensitive analysis #1509 )Closes #1507