Make privatization sync Join more precise when threadflag is path-sensitive#1475
Merged
Make privatization sync Join more precise when threadflag is path-sensitive#1475
sync Join more precise when threadflag is path-sensitive#1475Conversation
3 tasks
michael-schwarz
approved these changes
May 21, 2024
This was referenced Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1464, just enabling abortUnless caused two of our simple regression tests in sv-benchmarks to time out:
Tracing the first one revealed
MUTEX_INITSof relational mutex-meet getting additional unwidened increasing side-effects from the body of__VERIFIER_assert, in particular, the join point there. Thesync Joinwhich causes these is unnecessary in SV-COMP where threadflag is path-sensitive, so branched thread creation doesn't need to be accounted for by privatizations.Therefore, this PR makes such privatizations check that and avoid unnecessary side-effects from
sync Join. It fixes the two cases, which are probably somewhat outliers that they got an explosion of contexts with abortUnless.Really, this could make us both more precise (by side-effecting less crap to
MUTEX_INITSetc) and more efficient (not modifyingMUTEX_INITSwhich everything depends on).