Skip to content

stages/captcha: rework#9959

Merged
BeryJu merged 5 commits intomainfrom
stages/captcha/rework
Jun 4, 2024
Merged

stages/captcha: rework#9959
BeryJu merged 5 commits intomainfrom
stages/captcha/rework

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 3, 2024

Details

Adds a bunch of very dearly needed functionality to the captcha stage

  • Score Min/Max threshold (by default set to match recaptcha recommendation)
  • Continue/stop on error (when continuing, you can make custom decisions based on score, for example enable an MFA validation stage)
  • Better testing

closes #5971

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu
stages/captcha: rework
95b00b9 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners June 3, 2024 15:32
@netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit e8ca1a3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/665ed69de4bbb50008d04c9c
😎 Deploy Preview https://deploy-preview-9959--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit e8ca1a3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/665ed69d7d98390008807a80

@codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.63%. Comparing base (578ff13) to head (e8ca1a3).
Report is 3 commits behind head on main.

Files Patch % Lines
authentik/stages/captcha/stage.py 88.23% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9959      +/-   ##
==========================================
+ Coverage   92.62%   92.63%   +0.01%     
==========================================
  Files         711      711              
  Lines       34774    34823      +49     
==========================================
+ Hits        32208    32258      +50     
+ Misses       2566     2565       -1
Flag Coverage Δ
e2e 49.60% <12.28%> (-0.06%) ⬇️
integration 25.50% <10.52%> (-0.03%) ⬇️
unit 90.10% <96.49%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e8ca1a3701bf597dc0807bebf4685f3a839bc437-arm64

Afterwards, run the upgrade commands from the latest release notes.

rissson
rissson approved these changes Jun 3, 2024
View reviewed changes
BeryJu added 4 commits June 4, 2024 16:24
@BeryJu
update form with continue option
a400e5a 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
update docs, add notes for scores
2e79750 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
also only raise error from success if needed
a729ea2 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
return full data
e8ca1a3 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 6cf418a into main Jun 4, 2024
@BeryJu BeryJu deleted the stages/captcha/rework branch June 4, 2024 09:25
kensternberg-authentik added a commit that referenced this pull request Jun 11, 2024
@kensternberg-authentik
Merge branch 'main' into dev
312f364 
* main:
  web: bump API Client version (#9967)
  stages/captcha: rework (#9959)
  website/docs: fixed broken links to helm repo (#9960)
  core: bump pydantic from 2.7.2 to 2.7.3 (#9962)
  web: bump the wdio group in /tests/wdio with 4 updates (#9963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rissson rissson rissson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to use reCaptcha v3 with authentik

2 participants

@BeryJu @rissson