Skip to content

core: migrate all sessions to the database#9736

Merged
rissson merged 90 commits intomainfrom
database-sessions
Apr 11, 2025
Merged

core: migrate all sessions to the database#9736
rissson merged 90 commits intomainfrom
database-sessions

Conversation

@rissson
Copy link
Member

@rissson rissson commented May 15, 2024

Details


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this May 15, 2024
@rissson rissson requested a review from a team as a code owner May 15, 2024 11:37
@netlify
Copy link

netlify bot commented May 15, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit b8149c2
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66449fe5ae1fe900083843ee

@netlify
Copy link

netlify bot commented May 15, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit b8149c2
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66449fe56faef80008e790e0

@rissson rissson marked this pull request as draft October 17, 2024 12:02
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@netlify
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 9a5c9cb
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67eab65bb10fc8000846c6a5
😎 Deploy Preview https://deploy-preview-9736--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 9a5c9cb
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67eab65b2f0a210008428f84

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 76.69492% with 55 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (a5a0fa7) to head (9a5c9cb).
Report is 183 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/sessions.py 72.72% 24 Missing ⚠️
authentik/root/asgi_middleware.py 44.44% 15 Missing ⚠️
authentik/core/middleware.py 72.00% 7 Missing ⚠️
authentik/core/auth.py 16.66% 5 Missing ⚠️
authentik/core/models.py 93.75% 2 Missing ⚠️
authentik/lib/expression/evaluator.py 50.00% 1 Missing ⚠️
authentik/stages/user_login/middleware.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9736      +/-   ##
==========================================
- Coverage   92.79%   92.72%   -0.08%     
==========================================
  Files         795      795              
  Lines       40724    40831     +107     
==========================================
+ Hits        37791    37859      +68     
- Misses       2933     2972      +39     
Flag Coverage Δ
e2e 48.00% <65.67%> (+0.02%) ⬆️
integration 24.21% <31.35%> (+0.01%) ⬆️
unit 90.49% <76.69%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson mentioned this pull request Mar 13, 2025
6 tasks
rissson added 2 commits March 13, 2025 14:02
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson requested a review from a team as a code owner March 13, 2025 13:06
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rissson !

rissson added 10 commits March 19, 2025 17:00
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson enabled auto-merge (squash) March 31, 2025 15:36
Copy link
Collaborator

@gergosimonyi gergosimonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know the feeling when you jump from like 5 meters high into water? Like, you know it should be fine, but it's still so scary 😄 That's the feeling I have when I approve this.

@rissson rissson merged commit 395ad72 into main Apr 11, 2025
93 of 94 checks passed
@rissson rissson deleted the database-sessions branch April 11, 2025 07:10
gergosimonyi added a commit that referenced this pull request May 14, 2025
gergosimonyi added a commit that referenced this pull request May 14, 2025
* core: remove `OldAuthenticatedSession` content type

This was left out from #9736

* remove stale content types in `repair_permissions`

Co-authored-by: Jens Langhammer <jens@goauthentik.io>

* run `remove_stale_contenttypes` for each tenant

---------

Co-authored-by: Jens Langhammer <jens@goauthentik.io>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 14, 2025
* core: remove `OldAuthenticatedSession` content type

This was left out from #9736

* remove stale content types in `repair_permissions`

Co-authored-by: Jens Langhammer <jens@goauthentik.io>

* run `remove_stale_contenttypes` for each tenant

---------

Co-authored-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request May 14, 2025
…) (#14509)

core: remove `OldAuthenticatedSession` content type (#14507)

* core: remove `OldAuthenticatedSession` content type

This was left out from #9736

* remove stale content types in `repair_permissions`



* run `remove_stale_contenttypes` for each tenant

---------

Co-authored-by: Simonyi Gergő <28359278+gergosimonyi@users.noreply.github.com>
Co-authored-by: Jens Langhammer <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants