website/integrations: jellyfin: add OIDC configuration by Redlonghead · Pull Request #9538 · goauthentik/authentik

Redlonghead · 2024-05-02T02:22:57Z

Details

I added the OIDC configuration for Jellyfin so others would more likely see that they can do this option for SSO.

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2024-05-02T02:23:14Z

✅ Deploy Preview for authentik-docs ready!

Name	Link
🔨 Latest commit	`e3c42e1`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/6669fa78ecac7b00086a8bb9
😎 Deploy Preview	https://deploy-preview-9538--authentik-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-05-02T02:23:16Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`e3c42e1`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/6669fa788e85300008d546cd
😎 Deploy Preview	https://deploy-preview-9538--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-05-02T17:55:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (837a032) to head (e3c42e1).
Report is 59 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9538   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         713      713           
  Lines       34889    34894    +5     
=======================================
+ Hits        32322    32327    +5     
  Misses       2567     2567

Flag	Coverage Δ
e2e	`49.63% <ø> (-0.01%)`	⬇️
integration	`25.47% <ø> (-0.01%)`	⬇️
unit	`90.11% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tanberry

Thanks so much @Redlonghead for this contribution. I made a few edits (sorry you got caught up in a change we are making t our Style Guide; we use bold text for UI elements) but after those are done, let's merge!

tanberry · 2024-05-03T11:53:14Z

website/integrations/services/jellyfin/index.md

 2. Logout, and login with a LDAP user. Username **must** be used, logging in with email will not work.

-## authentik Configuration
+### Authentik Configuration


Suggested change

### Authentik Configuration

### authentik Configuration

:-) Our product name is actually lower-case, authentik.

Interesting, I just noticed that!

website/integrations/services/jellyfin/index.md

tanberry · 2024-05-03T12:22:14Z

website/integrations/services/jellyfin/index.md

+
+To use the role claim within Jellyfin we will have to add a custom property. This is not needed but does allow admins to be set for SSO users automatically. It can also deny access if they don't have a role, but this should be done though Authentik instead.
+
+1. Go to _Customization_ then _Property Mappings_


Suggested change

1. Go to _Customization_ then _Property Mappings_

1. In the Admin interface, go to **Customization -> Property Mappings**.

website/integrations/services/jellyfin/index.md

tanberry · 2024-05-15T21:07:20Z

website/integrations/services/jellyfin/index.md

+
+## OIDC Configuration
+
+### authentik Configuration


Consider switching the order of authentik and Jellyfin (on line 136) so they match the order in the LDAP section above... This would also help lessen the initial confusion of having two H3s that both say "authentik configuration". ;)

dominic-r

Placeholder such as ldap.company.com should be moved to thing.company to make the documentation more uniform.

dominic-r · 2024-06-11T14:56:16Z

@Redlonghead

website/integrations/services/jellyfin/index.md

changes made by contributor

tanberry

let's merge!

* main: website/docs: update 2024.6 release notes with latest changes (#10174) core: fix error when raising SkipObject in mapping (#10153) website/docs: 2024.6 release notes: add note about group names (#10170) website/docs: update 2024.6 release notes with latest changes (#10167) core: bump twilio from 9.1.1 to 9.2.0 (#10162) web: bump chromedriver from 126.0.1 to 126.0.2 in /tests/wdio (#10161) web: bump the wdio group in /tests/wdio with 4 updates (#10160) website/integrations: jellyfin: add OIDC configuration (#9538) website/docs: Describe where to apply the auto setup env vars (#9863) website/integrations: gitlab: better service description (#9923) web: fix docker build for non-release versions (#10154) root: makefile: add codespell to make-website (#10116)

Redlonghead added 3 commits May 1, 2024 20:38

Jellyfin OIDC Configuration Added

8f673d4

Merge branch 'goauthentik:main' into main

2109d6b

Formating

68b6f63

Redlonghead requested a review from a team as a code owner May 2, 2024 02:22

Redlonghead changed the title ~~Added Jellyfin OIDC Configuration~~ website/intergrations: Jellyfin: Added OIDC Configuration May 2, 2024

tanberry approved these changes May 3, 2024

View reviewed changes

Redlonghead added 2 commits May 3, 2024 23:02

Added code review suggestions

17442d4

Forgot some review changes

916bbdf

Redlonghead requested a review from tanberry May 3, 2024 23:12

tanberry reviewed May 15, 2024

View reviewed changes

tanberry added the status/reviewing thanks for opening, we're taking a look label May 15, 2024

Redlonghead added 2 commits May 19, 2024 19:51

More Changes

408dde1

Merge branch 'goauthentik:main' into main

38a61c0

rissson changed the title ~~website/intergrations: Jellyfin: Added OIDC Configuration~~ website/integrations: jellyfin: add OIDC configuration May 21, 2024

Redlonghead requested a review from tanberry May 25, 2024 03:55

dominic-r requested changes Jun 11, 2024

View reviewed changes

rissson requested changes Jun 11, 2024

View reviewed changes

website/integrations/services/jellyfin/index.md Outdated Show resolved Hide resolved

Redlonghead added 2 commits June 11, 2024 10:18

Merge branch 'goauthentik:main' into main

7fd26fc

Updated documentation

2fc2bb8

rissson previously requested changes Jun 12, 2024

View reviewed changes

website/integrations/services/jellyfin/index.md Outdated Show resolved Hide resolved

updated config order

e3c42e1

tanberry removed the status/reviewing thanks for opening, we're taking a look label Jun 18, 2024

tanberry approved these changes Jun 18, 2024

View reviewed changes

tanberry merged commit 7f17c5f into goauthentik:main Jun 18, 2024


		To use the role claim within Jellyfin we will have to add a custom property. This is not needed but does allow admins to be set for SSO users automatically. It can also deny access if they don't have a role, but this should be done though Authentik instead.

		1. Go to _Customization_ then _Property Mappings_

	1. Go to _Customization_ then _Property Mappings_
	1. In the Admin interface, go to Customization -> Property Mappings.

Uh oh!

Conversation

Redlonghead commented May 2, 2024

Details

Checklist

Uh oh!

netlify bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-docs ready!

Uh oh!

netlify bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook ready!

Uh oh!

codecov bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tanberry left a comment

Choose a reason for hiding this comment

Uh oh!

tanberry May 3, 2024

Choose a reason for hiding this comment

Uh oh!

tanberry May 3, 2024

Choose a reason for hiding this comment

Uh oh!

Redlonghead May 3, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tanberry May 3, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tanberry May 15, 2024

Choose a reason for hiding this comment

Uh oh!

Redlonghead May 20, 2024

Choose a reason for hiding this comment

Uh oh!

dominic-r left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominic-r commented Jun 11, 2024

Uh oh!

Uh oh!

Uh oh!

tanberry left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented May 2, 2024 •

edited

Loading

netlify bot commented May 2, 2024 •

edited

Loading

codecov bot commented May 2, 2024 •

edited

Loading

dominic-r left a comment •

edited

Loading