core: only prefetch related objects when required#9476
Merged
Conversation
Member
Author
|
/cherry-pick version-2024.4 |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
c4544cb to
8714407
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9476 +/- ##
==========================================
+ Coverage 92.41% 92.45% +0.03%
==========================================
Files 668 669 +1
Lines 32667 32712 +45
==========================================
+ Hits 30190 30243 +53
+ Misses 2477 2469 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-962dd5c990d0d88d275a6f3f298f1b4636593d76
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-962dd5c990d0d88d275a6f3f298f1b4636593d76-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-962dd5c990d0d88d275a6f3f298f1b4636593d76For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-962dd5c990d0d88d275a6f3f298f1b4636593d76-arm64Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* core: only prefetch related objects when required Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add tests Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add tests to assert query count Signed-off-by: Jens Langhammer <jens@goauthentik.io> * "optimize" another query away Signed-off-by: Jens Langhammer <jens@goauthentik.io> * prefetch parent and roles Signed-off-by: Jens Langhammer <jens@goauthentik.io> * whops that needs to be pre-fetched Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
added a commit
that referenced
this pull request
Apr 29, 2024
…#9510) core: only prefetch related objects when required (#9476) * core: only prefetch related objects when required * add tests * add tests to assert query count * "optimize" another query away * prefetch parent and roles * whops that needs to be pre-fetched --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 30, 2024
* main: (36 commits) providers/rac: bump guacd to 1.5.5 (#9514) core: only prefetch related objects when required (#9476) website/integrations: move Fortimanager to Networking (#9505) website: bump react-tooltip from 5.26.3 to 5.26.4 in /website (#9494) web: bump the rollup group in /web with 3 updates (#9497) web: bump yaml from 2.4.1 to 2.4.2 in /web (#9499) core: bump goauthentik.io/api/v3 from 3.2024040.1 to 3.2024041.1 (#9503) core: bump pytest from 8.1.1 to 8.2.0 (#9501) website: bump react-dom from 18.3.0 to 18.3.1 in /website (#9495) website: bump react and @types/react in /website (#9496) web: bump react-dom from 18.3.0 to 18.3.1 in /web (#9498) core: bump sentry-sdk from 2.0.0 to 2.0.1 (#9502) web/flows: fix missing fallback for flow logo (#9487) events: ensure all models' __str__ can be called without any further lookups (#9480) core, web: update translations (#9482) flows: fix execute API endpoint (#9478) sources/oauth: fix OAuth Client sending token request incorrectly (#9474) web: bump API Client version (#9473) release: 2024.4.1 website/docs: update release notes for 2024.4.1 again (#9471) ...
kensternberg-authentik
added a commit
that referenced
this pull request
May 3, 2024
* main: (43 commits) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9535) web: bump the rollup group across 1 directory with 3 updates (#9532) website/developer-docs: Add note for custom YAML tags in an IDE (#9528) lifecycle: close database connection after migrating (#9516) web: bump the babel group in /web with 3 updates (#9520) core: bump node from 21 to 22 (#9521) web: bump @codemirror/lang-python from 6.1.5 to 6.1.6 in /web (#9523) providers/rac: bump guacd to 1.5.5 (#9514) core: only prefetch related objects when required (#9476) website/integrations: move Fortimanager to Networking (#9505) website: bump react-tooltip from 5.26.3 to 5.26.4 in /website (#9494) web: bump the rollup group in /web with 3 updates (#9497) web: bump yaml from 2.4.1 to 2.4.2 in /web (#9499) core: bump goauthentik.io/api/v3 from 3.2024040.1 to 3.2024041.1 (#9503) core: bump pytest from 8.1.1 to 8.2.0 (#9501) website: bump react-dom from 18.3.0 to 18.3.1 in /website (#9495) website: bump react and @types/react in /website (#9496) web: bump react-dom from 18.3.0 to 18.3.1 in /web (#9498) core: bump sentry-sdk from 2.0.0 to 2.0.1 (#9502) web/flows: fix missing fallback for flow logo (#9487) ...
kensternberg-authentik
added a commit
that referenced
this pull request
May 6, 2024
* dev: (83 commits) website/docs: fix openssl rand commands (#9554) web: bump @sentry/browser from 7.112.2 to 7.113.0 in /web in the sentry group (#9549) core, web: update translations (#9548) core: bump goauthentik.io/api/v3 from 3.2024041.1 to 3.2024041.2 (#9551) core: bump django-model-utils from 4.5.0 to 4.5.1 (#9550) providers/scim: fix time_limit not set correctly (#9546) web/flows: fix error when enrolling multiple WebAuthn devices consecutively (#9545) web: bump ejs from 3.1.9 to 3.1.10 in /tests/wdio (#9542) web: bump API Client version (#9543) providers/saml: fix ecdsa support (#9537) website/integrations: nextcloud: connect to existing user (#9155) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9535) web: bump the rollup group across 1 directory with 3 updates (#9532) website/developer-docs: Add note for custom YAML tags in an IDE (#9528) lifecycle: close database connection after migrating (#9516) web: bump the babel group in /web with 3 updates (#9520) core: bump node from 21 to 22 (#9521) web: bump @codemirror/lang-python from 6.1.5 to 6.1.6 in /web (#9523) providers/rac: bump guacd to 1.5.5 (#9514) core: only prefetch related objects when required (#9476) ...
kensternberg-authentik
added a commit
that referenced
this pull request
May 6, 2024
…ore-dual-select-uses-2 * web/revision/more-dual-select-uses: (83 commits) website/docs: fix openssl rand commands (#9554) web: bump @sentry/browser from 7.112.2 to 7.113.0 in /web in the sentry group (#9549) core, web: update translations (#9548) core: bump goauthentik.io/api/v3 from 3.2024041.1 to 3.2024041.2 (#9551) core: bump django-model-utils from 4.5.0 to 4.5.1 (#9550) providers/scim: fix time_limit not set correctly (#9546) web/flows: fix error when enrolling multiple WebAuthn devices consecutively (#9545) web: bump ejs from 3.1.9 to 3.1.10 in /tests/wdio (#9542) web: bump API Client version (#9543) providers/saml: fix ecdsa support (#9537) website/integrations: nextcloud: connect to existing user (#9155) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9535) web: bump the rollup group across 1 directory with 3 updates (#9532) website/developer-docs: Add note for custom YAML tags in an IDE (#9528) lifecycle: close database connection after migrating (#9516) web: bump the babel group in /web with 3 updates (#9520) core: bump node from 21 to 22 (#9521) web: bump @codemirror/lang-python from 6.1.5 to 6.1.6 in /web (#9523) providers/rac: bump guacd to 1.5.5 (#9514) core: only prefetch related objects when required (#9476) ...
kensternberg-authentik
added a commit
that referenced
this pull request
May 6, 2024
* dev: (83 commits) website/docs: fix openssl rand commands (#9554) web: bump @sentry/browser from 7.112.2 to 7.113.0 in /web in the sentry group (#9549) core, web: update translations (#9548) core: bump goauthentik.io/api/v3 from 3.2024041.1 to 3.2024041.2 (#9551) core: bump django-model-utils from 4.5.0 to 4.5.1 (#9550) providers/scim: fix time_limit not set correctly (#9546) web/flows: fix error when enrolling multiple WebAuthn devices consecutively (#9545) web: bump ejs from 3.1.9 to 3.1.10 in /tests/wdio (#9542) web: bump API Client version (#9543) providers/saml: fix ecdsa support (#9537) website/integrations: nextcloud: connect to existing user (#9155) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9535) web: bump the rollup group across 1 directory with 3 updates (#9532) website/developer-docs: Add note for custom YAML tags in an IDE (#9528) lifecycle: close database connection after migrating (#9516) web: bump the babel group in /web with 3 updates (#9520) core: bump node from 21 to 22 (#9521) web: bump @codemirror/lang-python from 6.1.5 to 6.1.6 in /web (#9523) providers/rac: bump guacd to 1.5.5 (#9514) core: only prefetch related objects when required (#9476) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Currently we prefetch related objects for user/group queries even when explicitly set to not include those objects in the API response
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)