web: Add resolved and integrity fields back to package-lock.json#9419
Merged
BeryJu merged 2 commits intogoauthentik:mainfrom Apr 25, 2024
Merged
web: Add resolved and integrity fields back to package-lock.json#9419BeryJu merged 2 commits intogoauthentik:mainfrom
BeryJu merged 2 commits intogoauthentik:mainfrom
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Thanks for the PR and also providing a way to prevent this from happening in the future! I'm not sure if this can easily be cherry-picked to 2024.4, but will try once this is merged |
Member
|
/cherry-pick version-2024.4 |
BeryJu
approved these changes
Apr 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9419 +/- ##
==========================================
- Coverage 92.42% 92.41% -0.01%
==========================================
Files 668 668
Lines 32669 32669
==========================================
- Hits 30194 30192 -2
- Misses 2475 2477 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
* web: Fix missing resolved and integrity fields in package-lock.json * web,website: Add lockfile lint to CI
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 30, 2024
* main: web: clean up some repetitive types (#9241) core: fix logic for token expiration (#9426) ci: fix ci pipeline (#9427) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9424) web: Add resolved and integrity fields back to package-lock.json (#9419) translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9407) stages/identification: don't check source component (#9410) core: bump selenium from 4.19.0 to 4.20.0 (#9411) core: bump black from 24.4.0 to 24.4.1 (#9412) ci: bump golangci/golangci-lint-action from 4 to 5 (#9413) core: bump goauthentik.io/api/v3 from 3.2024023.2 to 3.2024040.1 (#9414) web: bump @sentry/browser from 7.112.1 to 7.112.2 in /web in the sentry group (#9416) sources/oauth: ensure all UI sources return a valid source (#9401) web: markdown: display markdown even when frontmatter is missing (#9404)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6180
This also adds a new job in CI that checks that the lockfile is fully resolved, so this does not happen again in the future
I fixed the lockfile with
cd website nix run github:jeslie0/npm-lockfile-fix ./package-lock.json npm install