Skip to content

core: replace authentik_signals_ignored_fields with audit_ignore#9291

Merged
BeryJu merged 1 commit intomainfrom
events/fix-inconsistencies
Apr 16, 2024
Merged

core: replace authentik_signals_ignored_fields with audit_ignore#9291
BeryJu merged 1 commit intomainfrom
events/fix-inconsistencies

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 16, 2024

Details

authentik_signals_ignored_fields is only respected by the enterprise audit middleware, which causes user logins to create two events on non-enterprise installs, as a model_updated event is logged, which the audit middleware correctly discards.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu marked this pull request as ready for review April 16, 2024 15:34
@BeryJu BeryJu requested a review from a team as a code owner April 16, 2024 15:34
@netlify
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit efd0db4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/661eeec2d232f00008317b6f

@netlify
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit efd0db4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/661eeec2d66a78000805e85e

@codecov
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (89c841b) to head (efd0db4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9291   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         665      665           
  Lines       32617    32613    -4     
=======================================
- Hits        30135    30132    -3     
+ Misses       2482     2481    -1     
Flag Coverage Δ
e2e 50.67% <100.00%> (+0.01%) ⬆️
integration 26.01% <33.33%> (+<0.01%) ⬆️
unit 89.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-0a75af9f94acd75296b68425d8a4c6caf08836b2
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-0a75af9f94acd75296b68425d8a4c6caf08836b2-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-0a75af9f94acd75296b68425d8a4c6caf08836b2

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-0a75af9f94acd75296b68425d8a4c6caf08836b2-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the events/fix-inconsistencies branch from 0a75af9 to efd0db4 Compare April 16, 2024 21:33
@BeryJu BeryJu merged commit 14fab99 into main Apr 16, 2024
@BeryJu BeryJu deleted the events/fix-inconsistencies branch April 16, 2024 22:19
kensternberg-authentik added a commit that referenced this pull request Apr 18, 2024
* main: (23 commits)
  web: bump API Client version (#9316)
  release: 2024.2.3
  website/docs: 2024.2.3 release notes (#9313)
  web/admin: fix log viewer empty state (#9315)
  website/docs: fix formatting for stage changes (#9314)
  core: bump github.com/go-ldap/ldap/v3 from 3.4.7 to 3.4.8 (#9310)
  core: bump goauthentik.io/api/v3 from 3.2024022.11 to 3.2024022.12 (#9311)
  web: bump core-js from 3.36.1 to 3.37.0 in /web (#9309)
  core: bump gunicorn from 21.2.0 to 22.0.0 (#9308)
  core, web: update translations (#9307)
  website/docs: system settings: add default token duration and length (#9306)
  web/flows: update flow background (#9305)
  web: fix locale loading being skipped (#9301)
  translate: Updates for file web/xliff/en.xlf in fr (#9304)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#9303)
  core: replace authentik_signals_ignored_fields with audit_ignore (#9291)
  web/flow: fix form input rendering issue (#9297)
  events: fix incorrect user logged when using API token authentication (#9302)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9293)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9295)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant