Skip to content

sources/oauth: make URLs not required, only check when no OIDC URLs are defined#9182

Merged
BeryJu merged 1 commit intomainfrom
sources/oauth/make-urls-not-required
Apr 9, 2024
Merged

sources/oauth: make URLs not required, only check when no OIDC URLs are defined#9182
BeryJu merged 1 commit intomainfrom
sources/oauth/make-urls-not-required

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 8, 2024

Details

closes #9176


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…re defined

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners April 8, 2024 22:48
@netlify
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 9de37c5
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66147440d08e430008cba329
😎 Deploy Preview https://deploy-preview-9182--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 9de37c5
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66147440ea8e220008772e2f

@codecov
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (16b8edd) to head (9de37c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9182      +/-   ##
==========================================
- Coverage   92.40%   92.40%   -0.01%     
==========================================
  Files         646      646              
  Lines       31801    31801              
==========================================
- Hits        29386    29385       -1     
- Misses       2415     2416       +1     
Flag Coverage Δ
e2e 50.52% <100.00%> (-0.01%) ⬇️
integration 26.22% <0.00%> (ø)
unit 89.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-9de37c598540501360093399c3c52015e9188261
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-9de37c598540501360093399c3c52015e9188261-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-9de37c598540501360093399c3c52015e9188261

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-9de37c598540501360093399c3c52015e9188261-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit d24fe25 into main Apr 9, 2024
@BeryJu BeryJu deleted the sources/oauth/make-urls-not-required branch April 9, 2024 18:35
kensternberg-authentik added a commit that referenced this pull request Apr 11, 2024
* main:
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9194)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9197)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#9196)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#9198)
  web: preserve selected list when provider updates (#9200)
  web: bump API Client version (#9195)
  sources/oauth: make URLs not required, only check when no OIDC URLs are defined (#9182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC Well-known URL won't configure endpoint URLs

1 participant