website/docs: email stage: fix example translation error#9048
Merged
tanberry merged 1 commit intogoauthentik:mainfrom Apr 1, 2024
Merged
website/docs: email stage: fix example translation error#9048tanberry merged 1 commit intogoauthentik:mainfrom
tanberry merged 1 commit intogoauthentik:mainfrom
Conversation
fixed configuration_error django.template.exceptions.TemplateSyntaxError: 'blocktrans' doesn't allow other block tags (seen 'blocktrans') inside it Signed-off-by: Leonard Klausmann <41154624+schnadoslin@users.noreply.github.com>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9048 +/- ##
===========================================
+ Coverage 46.62% 92.33% +45.70%
===========================================
Files 626 640 +14
Lines 30996 31555 +559
===========================================
+ Hits 14451 29135 +14684
+ Misses 16545 2420 -14125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeryJu
reviewed
Apr 1, 2024
Member
BeryJu
left a comment
There was a problem hiding this comment.
I don't see why this change is needed as within the blocktrans block there is no other block?
Contributor
|
True, @BeryJu it's not really needed as the block is now, but allows for future changes. Let's merge it. Thanks @schnadoslin for this; at very least I learned a bit of Django. ;-) |
tanberry
approved these changes
Apr 1, 2024
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 4, 2024
* main: root: fix missing imports after #9081 (#9106) root: move database calls from ready() to dedicated startup signal (#9081) web: fix console log leftover (#9096) web: bump the eslint group in /web with 2 updates (#9098) core: bump twilio from 9.0.2 to 9.0.3 (#9103) web: bump the eslint group in /tests/wdio with 2 updates (#9099) core: bump drf-spectacular from 0.27.1 to 0.27.2 (#9100) core: bump django-model-utils from 4.4.0 to 4.5.0 (#9101) core: bump ruff from 0.3.4 to 0.3.5 (#9102) website/docs: update notes on SECRET_KEY (#9091) web: fix broken locale compile (#9095) website/integrations: add outline knowledge base (#8786) website/docs: fix typo (#9082) website/docs: email stage: fix example translation error (#9048)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed configuration_error
django.template.exceptions.TemplateSyntaxError: 'blocktrans' doesn't allow other block tags (seen 'blocktrans') inside it
👋 Hi there!
Details
website/docs : flow/stages/email)
Given template on website was faulty.