web/admin: fix markdown table rendering by kensternberg-authentik · Pull Request #8908 · goauthentik/authentik

kensternberg-authentik · 2024-03-14T15:29:20Z

Details

web: fix markdown table rendering

“Render Markdown Tables” is not on by default in snowdown; this commit activates it. In a “You touched it, now you have to fix it” moment, Sonar has me fixing a little lint along the way.

Checklist

If changes to the frontend have been made

The code has been formatted (make web)

Getting ESBuild, Lit, and Storybook to all agree on how to read and parse stylesheets is a serious pain. This fix better identifies the value types (instances) being passed from various sources in the repo to the three *different* kinds of style processors we're using (the native one, the polyfill one, and whatever the heck Storybook does internally). Falling back to using older CSS instantiating techniques one era at a time seems to do the trick. It's ugly, but in the face of the aggressive styling we use to avoid Flashes of Unstyled Content (FLoUC), it's the logic with which we're left. In standard mode, the following warning appears on the console when running a Flow: ``` Autofocus processing was blocked because a document already has a focused element. ``` In compatibility mode, the following **error** appears on the console when running a Flow: ``` crawler-inject.js:1106 Uncaught TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'. at initDomMutationObservers (crawler-inject.js:1106:18) at crawler-inject.js:1114:24 at Array.forEach (<anonymous>) at initDomMutationObservers (crawler-inject.js:1114:10) at crawler-inject.js:1549:1 initDomMutationObservers @ crawler-inject.js:1106 (anonymous) @ crawler-inject.js:1114 initDomMutationObservers @ crawler-inject.js:1114 (anonymous) @ crawler-inject.js:1549 ``` Despite this error, nothing seems to be broken and flows work as anticipated.

* main: tenants: really ensure default tenant cannot be deleted (#8875) core: bump github.com/go-openapi/runtime from 0.27.2 to 0.28.0 (#8867) core: bump pytest from 8.0.2 to 8.1.1 (#8868) core: bump github.com/go-openapi/strfmt from 0.22.2 to 0.23.0 (#8869) core: bump bandit from 1.7.7 to 1.7.8 (#8870) core: bump packaging from 23.2 to 24.0 (#8871) core: bump ruff from 0.3.1 to 0.3.2 (#8873) web: bump the wdio group in /tests/wdio with 3 updates (#8865) core: bump requests-oauthlib from 1.3.1 to 1.4.0 (#8866) core: bump uvicorn from 0.27.1 to 0.28.0 (#8872) core: bump django-filter from 23.5 to 24.1 (#8874)

* main: web: fix esbuild issue with style sheets (#8856)

* main: web: upgrade to lit 3 (#8781)

* main: Update _envoy_istio.md (#8888) website/docs: new landing page for Providers (#8879) web: bump the sentry group in /web with 1 update (#8881) web: bump chromedriver from 122.0.4 to 122.0.5 in /tests/wdio (#8884) web: bump the eslint group in /tests/wdio with 2 updates (#8883) web: bump the eslint group in /web with 2 updates (#8885) website: bump @types/react from 18.2.64 to 18.2.65 in /website (#8886)

* main: api: capabilities: properly set can_save_media when s3 is enabled (#8896) web: bump the rollup group in /web with 3 updates (#8891) core: bump pydantic from 2.6.3 to 2.6.4 (#8892) core: bump twilio from 9.0.0 to 9.0.1 (#8893)

* main: web: bump chromedriver from 122.0.5 to 122.0.6 in /tests/wdio (#8902) web: bump vite-tsconfig-paths from 4.3.1 to 4.3.2 in /web (#8903) core: bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#8901) web: provide InstallID on EnterpriseListPage (#8898)

"Render Markdown Tables" is not on by default in `snowdown`; this commit activates it. In a "You touched it, now you have to fix it" moment, Sonar has me fixing a little lint along the way.

netlify · 2024-03-14T15:29:36Z

✅ Deploy Preview for authentik-docs canceled.

Name	Link
🔨 Latest commit	`51ea2e9`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-docs/deploys/65f317d2b64cad0008394849

netlify · 2024-03-14T15:29:37Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`51ea2e9`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/65f317d267024f00089d2084
😎 Deploy Preview	https://deploy-preview-8908--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kensternberg-authentik · 2024-03-14T15:29:41Z

web/src/elements/Markdown.ts

    }

-    converter = new showdown.Converter({ metadata: true });
+    converter = new showdown.Converter({ metadata: true, tables: true });


This is the only real fix.

kensternberg-authentik · 2024-03-14T15:30:26Z

web/src/elements/Markdown.ts

            const url = new URL(link, baseUrl).toString();
            return `href="${url}" _target="blank"`;
        });
-        return result;


Lint's doing that "You touched it, now you have to fix the linty issues" thing, like an unneeded intermediate value and an unused iterator value.

github-actions · 2024-03-14T15:49:53Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-51ea2e9f44d61e3a3f5094a8c57d15c6a5c016cb
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-51ea2e9f44d61e3a3f5094a8c57d15c6a5c016cb-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-51ea2e9f44d61e3a3f5094a8c57d15c6a5c016cb

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-51ea2e9f44d61e3a3f5094a8c57d15c6a5c016cb-arm64

Afterwards, run the upgrade commands from the latest release notes.

* main: web: clean up and remove redundant alias '@goauthentik/app' (#8889) web/admin: fix markdown table rendering (#8908)

kensternberg-authentik added 8 commits March 8, 2024 14:15

Merge branch 'main' into dev

e505f27

* main: web: fix esbuild issue with style sheets (#8856)

Merge branch 'main' into dev

5090621

* main: web: upgrade to lit 3 (#8781)

Merge branch 'main' into dev

2d0117d

* main: api: capabilities: properly set can_save_media when s3 is enabled (#8896) web: bump the rollup group in /web with 3 updates (#8891) core: bump pydantic from 2.6.3 to 2.6.4 (#8892) core: bump twilio from 9.0.0 to 9.0.1 (#8893)

web: fix markdown table rendering

51ea2e9

"Render Markdown Tables" is not on by default in `snowdown`; this commit activates it. In a "You touched it, now you have to fix it" moment, Sonar has me fixing a little lint along the way.

kensternberg-authentik commented Mar 14, 2024

View reviewed changes

kensternberg-authentik marked this pull request as ready for review March 14, 2024 15:30

kensternberg-authentik requested a review from a team as a code owner March 14, 2024 15:30

BeryJu changed the title ~~Web: fix markdown table rendering~~ web/admin: fix markdown table rendering Mar 14, 2024

BeryJu approved these changes Mar 14, 2024

View reviewed changes

kensternberg-authentik merged commit 7720480 into main Mar 14, 2024

kensternberg-authentik deleted the web/bug/fix-markdown-table-rendering branch March 14, 2024 15:49

kensternberg-authentik added a commit that referenced this pull request Mar 14, 2024

Merge branch 'main' into dev

8b4e036

* main: web: clean up and remove redundant alias '@goauthentik/app' (#8889) web/admin: fix markdown table rendering (#8908)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

web/admin: fix markdown table rendering#8908

web/admin: fix markdown table rendering#8908
kensternberg-authentik merged 8 commits intomainfrom
web/bug/fix-markdown-table-rendering

kensternberg-authentik commented Mar 14, 2024

Uh oh!

netlify bot commented Mar 14, 2024 •

edited

Loading

Uh oh!

netlify bot commented Mar 14, 2024 •

edited

Loading

Uh oh!

kensternberg-authentik Mar 14, 2024

Uh oh!

kensternberg-authentik Mar 14, 2024

Uh oh!

github-actions bot commented Mar 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kensternberg-authentik commented Mar 14, 2024

Details

Checklist

Uh oh!

netlify bot commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-docs canceled.

Uh oh!

netlify bot commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook ready!

Uh oh!

kensternberg-authentik Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

kensternberg-authentik Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Mar 14, 2024 •

edited

Loading

netlify bot commented Mar 14, 2024 •

edited

Loading