Skip to content

sources/oauth: add gitlab type [AUTH-323]#8195

Merged
BeryJu merged 5 commits intomainfrom
smusali/gitlab-oauth
Feb 29, 2024
Merged

sources/oauth: add gitlab type [AUTH-323]#8195
BeryJu merged 5 commits intomainfrom
smusali/gitlab-oauth

Conversation

@smusali
Copy link
Contributor

@smusali smusali commented Jan 16, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@smusali smusali added enhancement New feature or request python from_authentik Issues created through a link from authentik (https://goauthentik.io/docs/events/#system_exception) enhancement/confirmed Enhancements that will be implemented in the future labels Jan 16, 2024
@smusali smusali self-assigned this Jan 16, 2024
@smusali smusali requested review from a team as code owners January 16, 2024 12:06
@notion-workspace
Copy link

GitLab OAuth Source

@netlify
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 1639d37
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65e088f4a383230008205584
😎 Deploy Preview https://deploy-preview-8195--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.36%. Comparing base (cef1d2d) to head (54e197f).
Report is 235 commits behind head on main.

❗ Current head 54e197f differs from pull request most recent head 1639d37. Consider uploading reports for the commit 1639d37 to get more accurate results

Files Patch % Lines
authentik/sources/oauth/types/gitlab.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8195       +/-   ##
===========================================
+ Coverage   46.62%   64.36%   +17.74%     
===========================================
  Files         626      493      -133     
  Lines       30996    24854     -6142     
===========================================
+ Hits        14451    15997     +1546     
+ Misses      16545     8857     -7688     
Flag Coverage Δ
e2e 62.40% <96.15%> (+17.68%) ⬆️
integration 32.47% <96.15%> (+6.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smusali smusali force-pushed the smusali/gitlab-oauth branch from c4a0bcf to c18767b Compare January 16, 2024 12:19
@github-actions
Copy link
Contributor

authentik translations instructions

Thanks for your pull request!

authentik translations are handled using Transifex. Please edit translations over there and they'll be included automatically.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-1639d3723a60c502f2a88ebe8d2aa918803e1e0a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-1639d3723a60c502f2a88ebe8d2aa918803e1e0a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-1639d3723a60c502f2a88ebe8d2aa918803e1e0a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-1639d3723a60c502f2a88ebe8d2aa918803e1e0a-arm64

Afterwards, run the upgrade commands from the latest release notes.

@smusali smusali force-pushed the smusali/gitlab-oauth branch 2 times, most recently from 567c7e7 to 4f657db Compare January 22, 2024 12:45
@netlify
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit cdd103c
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65d34eeaeef2b200081861b3
😎 Deploy Preview https://deploy-preview-8195--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@smusali smusali force-pushed the smusali/gitlab-oauth branch from 4f657db to 216bdbf Compare January 23, 2024 12:08
@smusali smusali force-pushed the smusali/gitlab-oauth branch 2 times, most recently from 54e197f to 3d4910a Compare February 5, 2024 13:18
Samir Musali and others added 5 commits February 29, 2024 14:38
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the smusali/gitlab-oauth branch from 46fc021 to 1639d37 Compare February 29, 2024 13:38
@BeryJu BeryJu removed the from_authentik Issues created through a link from authentik (https://goauthentik.io/docs/events/#system_exception) label Feb 29, 2024
@netlify
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 1639d37
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/65e088f4f19c6000080dcc28
😎 Deploy Preview https://deploy-preview-8195--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu BeryJu merged commit 1b24168 into main Feb 29, 2024
@BeryJu BeryJu deleted the smusali/gitlab-oauth branch February 29, 2024 15:53
kensternberg-authentik added a commit that referenced this pull request Feb 29, 2024
* main:
  web: bump API Client version (#8753)
  sources/oauth: add gitlab type [AUTH-323] (#8195)
  web: bump the babel group in /web with 4 updates (#8744)
  web: bump @types/grecaptcha from 3.0.7 to 3.0.8 in /web (#8745)
  web: bump chart.js from 4.4.1 to 4.4.2 in /web (#8746)
  web: bump chromedriver from 122.0.3 to 122.0.4 in /tests/wdio (#8747)
  core, web: update translations (#8743)
  ci: fix missing output on composite action (#8741)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants