Skip to content

outpost: improved set secret answers for flow execution#8013

Merged
BeryJu merged 3 commits intogoauthentik:mainfrom
sirux88:radius-improvements
Mar 15, 2024
Merged

outpost: improved set secret answers for flow execution#8013
BeryJu merged 3 commits intogoauthentik:mainfrom
sirux88:radius-improvements

Conversation

@sirux88
Copy link
Contributor

@sirux88 sirux88 commented Dec 29, 2023 •
edited
Loading

Details

Set the flow answer for StageAuthenticatorValidate equal to StagePassword if code-based MFA is not enabled.
This change is valid for the radius outpost handle function.

Reason for this PR is:
I need to validate a user's MFA (in my case a TOTP token) against authentik which is not possible in its current state
(Password validation is done by an other system)

A possible but very dirty workaround would be to prepend a semicolon to the MFA token. But my system doesn't allow this.

As a sidemark:
If necessary this could be implemented for ldap outpost aswell.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@sirux88 sirux88 requested review from a team as code owners December 29, 2023 18:35
@netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 599dbf6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65f47d7c2190220008d148d5
😎 Deploy Preview https://deploy-preview-8013--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sirux88 sirux88 force-pushed the radius-improvements branch from d9b4e18 to cec0211 Compare December 29, 2023 18:36
BeryJu
BeryJu reviewed Dec 29, 2023
View reviewed changes
@netlify
Copy link

netlify bot commented Jan 2, 2024

✅ Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 658b37c
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6593ea1277e5950008ee9d11
😎 Deploy Preview https://deploy-preview-8013--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sirux88
Copy link
Contributor Author

sirux88 commented Jan 2, 2024

I implemented SetSecrets function for radius and ldap outposts @BeryJu

@sirux88 sirux88 changed the title outpost/radius: set mfa answer for noncode-based mfa outpost: improved set secret answers for flow execution Jan 2, 2024
@sirux88 sirux88 requested a review from BeryJu January 9, 2024 15:12
@tanberry tanberry added the status/reviewing thanks for opening, we're taking a look label Feb 23, 2024
@sirux88 sirux88 force-pushed the radius-improvements branch from 658b37c to 5accbb7 Compare March 5, 2024 19:16
@netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 599dbf6
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/65f47d7c6167ae00080ff9fd
😎 Deploy Preview https://deploy-preview-8013--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sirux88
Copy link
Contributor Author

sirux88 commented Mar 5, 2024 •
edited
Loading

Is there anything I can help you with or provide to get this merged @tanberry ?

@codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (cef1d2d) to head (5accbb7).
Report is 348 commits behind head on main.

❗ Current head 5accbb7 differs from pull request most recent head 599dbf6. Consider uploading reports for the commit 599dbf6 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #8013       +/-   ##
===========================================
+ Coverage   46.62%   92.25%   +45.63%     
===========================================
  Files         626      634        +8     
  Lines       30996    31340      +344     
===========================================
+ Hits        14451    28914    +14463     
+ Misses      16545     2426    -14119
Flag Coverage Δ
e2e 49.28% <ø> (+4.56%) ⬆️
integration 26.08% <ø> (+0.09%) ⬆️
unit 89.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanberry
Copy link
Contributor

tanberry commented Mar 6, 2024

Hi @sirux88, in reviewing the build fails I found a tiny typo (you can just approve my suggestion and it will be added to your PR), and then @BeryJu is going to give it another technical review. Thanks, we'll get it merged soon!

@sirux88
Copy link
Contributor Author

sirux88 commented Mar 6, 2024

Hi @sirux88, in reviewing the build fails I found a tiny typo (you can just approve my suggestion and it will be added to your PR), and then @BeryJu is going to give it another technical review. Thanks, we'll get it merged soon!

I can't find your suggestion. Did I miss something?
The only typo I could find is "acccording" with an "c" to much.
Is this what you are talking about @tanberry ? If so I'll fix it.

@BeryJu
small style changes
599dbf6 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 3f43ff2 into goauthentik:main Mar 15, 2024
@sirux88 sirux88 deleted the radius-improvements branch March 17, 2024 07:28
kensternberg-authentik added a commit that referenced this pull request Mar 18, 2024
@kensternberg-authentik
Merge branch 'main' into dev
db96e1a 
* main: (31 commits)
  root: support redis username (#8935)
  core: bump black from 24.2.0 to 24.3.0 (#8945)
  web: bump the wdio group in /tests/wdio with 2 updates (#8939)
  web: bump the sentry group in /web with 1 update (#8941)
  website: bump postcss from 8.4.35 to 8.4.36 in /website (#8940)
  core: bump twilio from 9.0.1 to 9.0.2 (#8942)
  core: bump ruff from 0.3.2 to 0.3.3 (#8943)
  events: discard notification if user has empty email (#8938)
  ci: always run ci-main on branch pushes (#8950)
  core: bump goauthentik.io/api/v3 from 3.2024022.2 to 3.2024022.3 (#8946)
  website/docs: add new name "Microsft Entra ID" for Azure AD  (#8930)
  outposts: Enhance config options for k8s outposts (#7363)
  website/docs: add link to CRUD docs (#8925)
  web: bump API Client version (#8927)
  outpost: improved set secret answers for flow execution (#8013)
  stages/user_write: ensure user data is json-serializable (#8926)
  website/docs: update example ldapsearch commands (#8906)
  admin: Handle latest  version unknown in admin dashboard (#8858)
  core: bump coverage from 7.4.3 to 7.4.4 (#8917)
  core: bump urllib3 from 1.26.18 to 2.2.1 (#8918)
  ...
@tim-at-gith tim-at-gith mentioned this pull request Mar 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BeryJu BeryJu BeryJu approved these changes

Assignees

No one assigned

Labels

status/reviewing thanks for opening, we're taking a look

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sirux88 @tanberry @BeryJu