Conversation
Ever see an idiom that just, I dunno, *annoyed* you? Automated tools for the win.
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7830 +/- ##
===========================================
+ Coverage 43.71% 92.63% +48.92%
===========================================
Files 588 588
Lines 29200 29200
===========================================
+ Hits 12764 27049 +14285
+ Misses 16436 2151 -14285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…y type for for Providers, Sources, and Stages.
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* main: scripts: postgres, redis: only listen on localhost (#7849) website: bump @types/react from 18.2.42 to 18.2.43 in /website (#7840) web: bump ts-node from 10.9.1 to 10.9.2 in /tests/wdio (#7846) core: bump github.com/go-openapi/runtime from 0.26.0 to 0.26.2 (#7841) website: bump prettier from 3.1.0 to 3.1.1 in /website (#7839) web: bump the esbuild group in /web with 2 updates (#7842) web: bump rollup from 4.6.1 to 4.7.0 in /web (#7843) web: bump prettier from 3.1.0 to 3.1.1 in /web (#7844) web: bump the wdio group in /tests/wdio with 2 updates (#7845) web: bump prettier from 3.1.0 to 3.1.1 in /tests/wdio (#7847) translate: Updates for file web/xliff/en.xlf in fr (#7851) translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#7850) core: bump python from 3.12.0-slim-bookworm to 3.12.1-slim-bookworm web/flows: update flow background (#7833) web/flows: fix logo height (#7834) Fix cache related image build issues
BeryJu
approved these changes
Dec 12, 2023
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 8, 2024
* main: web: dark/light theme fixes (#7872) web: replace 'description-list' with list of descriptions (#7392) web: expressing success (#7830) web: fix turnstile types after update (#7854) core: bump github.com/google/uuid from 1.4.0 to 1.5.0 (#7866) website: bump @types/react from 18.2.43 to 18.2.45 in /website (#7865) web: bump wdio-wait-for from 3.0.9 to 3.0.10 in /tests/wdio (#7867) website/blog: okta part two blog (#7863) web: bump lit-analyzer from 2.0.1 to 2.0.2 in /web (#7858) web: bump the babel group in /web with 4 updates (#7856) web: bump the eslint group in /web with 2 updates (#7857) web: bump rollup from 4.7.0 to 4.8.0 in /web (#7859) web: bump the eslint group in /tests/wdio with 2 updates (#7860) web: refactor the table renderer for legibility (#7433) documentation: Improve explanation of `kubernetes_json_patches` (#7832) root: update security policy to include link to cure53 report (#7853)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Ever see an idiom that just, I dunno, annoyed you?
This commit converts 56
ifstatements in which both branches are of the same shape and type ("success message") intoifexpressions. It also extracts repeated instances of the function that produces those success messages into abstract parent classes for a variety of child forms that use the same base model on the Django side: Policy, PropertyMapping, Provider, Source, and Stage. A nice win is that each of these makes concrete and clear the primary key type for those base models.All of this was done with a pair of "automated" tools; syntactical tools, true, but still automated. And ESLint, Prettier, SonarJS and TSC all kept me honest. Automated tools for the win.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)