Skip to content

website/integrations: add FreshRSS#7301

Merged
rissson merged 1 commit intogoauthentik:mainfrom
foux:freshrss-documentation
Nov 7, 2023
Merged

website/integrations: add FreshRSS#7301
rissson merged 1 commit intogoauthentik:mainfrom
foux:freshrss-documentation

Conversation

@foux
Copy link
Contributor

@foux foux commented Oct 25, 2023

Details

This PR adds community documentation to login to FreshRSS with Authentik

  • The documentation has been updated
  • The documentation has been formatted (make website)

@foux foux requested a review from a team as a code owner October 25, 2023 19:27
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit a157d1d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/654a35080ec6a20008372bd6
😎 Deploy Preview https://deploy-preview-7301--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@foux foux mentioned this pull request Oct 25, 2023
Closed
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for authentik ready!

Name Link
🔨 Latest commit a157d1d
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/654a3508dfb2ed00080f9d55
😎 Deploy Preview https://deploy-preview-7301--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@XtremeOwnageDotCom
Copy link

XtremeOwnageDotCom commented Oct 25, 2023 •
edited
Loading

As a note- I noticed this line-

:::info
This integration only works with the Docker install of FreshRSS, using FreshRSS docker image, on x86_64 systems and with
the Debian version of the image.

I can confirm, it will work with kubernetes too. Which- is where I based my version of the documentation from. Just- make sure to use the FreshRSS/FreshRSS repo, and not linuxserver/FreshRSS

@foux foux force-pushed the freshrss-documentation branch from 26e610f to 86362bc Compare October 26, 2023 07:43
@Alkarex
Copy link

Alkarex commented Oct 26, 2023

You could consider adding a link to
https://freshrss.github.io/FreshRSS/en/admins/16_OpenID-Connect-Authentik.html
or
https://freshrss.github.io/FreshRSS/en/admins/16_OpenID-Connect.html
depending on what makes more sense

@foux
Copy link
Contributor Author

foux commented Oct 26, 2023

You could consider adding a link to https://freshrss.github.io/FreshRSS/en/admins/16_OpenID-Connect-Authentik.html or https://freshrss.github.io/FreshRSS/en/admins/16_OpenID-Connect.html depending on what makes more sense

Done. I've added link to the FreshRSS documentation. You can see what the doc will look like here : https://deploy-preview-7301--authentik.netlify.app/integrations/services/freshrss/

@foux foux force-pushed the freshrss-documentation branch from 175e034 to ca14400 Compare October 26, 2023 08:04
rissson
rissson requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@rissson rissson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your contribution! A few nitpicks here and there to align a bit more with what's done for the rest of the documentation, but looks very good overall.
I'm a bit unsure about some of the stuff about the reverse proxy, I'll need to look into the freshrss documentation a bit more.

@foux foux force-pushed the freshrss-documentation branch from 0ec171f to 3145428 Compare October 26, 2023 13:26
@foux foux requested a review from rissson October 28, 2023 07:10
@foux foux force-pushed the freshrss-documentation branch from 3145428 to c82d4dc Compare October 28, 2023 07:31
@foux
Copy link
Contributor Author

foux commented Oct 30, 2023

@rissson is everything good for you?

@foux foux force-pushed the freshrss-documentation branch from c82d4dc to a16d31b Compare October 30, 2023 12:31
@rissson rissson changed the title Add FreshRSS documentation website/integrations: add FreshRSS Oct 30, 2023
@rissson rissson requested a review from tanberry October 30, 2023 12:32
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (293fa2e) 92.59% compared to head (a157d1d) 92.59%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7301   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         587      587           
  Lines       28898    28898           
=======================================
  Hits        26757    26757           
  Misses       2141     2141
Flag Coverage Δ
e2e 50.93% <ø> (ø)
integration 26.01% <ø> (ø)
unit 89.59% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@foux
Copy link
Contributor Author

foux commented Oct 30, 2023

Damn codespell ;)
It is fixed

@foux foux force-pushed the freshrss-documentation branch from 2ab7668 to 9f38ea7 Compare October 31, 2023 09:47
@foux foux force-pushed the freshrss-documentation branch from 9f38ea7 to a157d1d Compare November 7, 2023 13:00
@foux
Copy link
Contributor Author

foux commented Nov 7, 2023

@rissson can we please relauch the checks?
Thanks

@rissson rissson merged commit aadda1f into goauthentik:main Nov 7, 2023
kensternberg-authentik added a commit that referenced this pull request Nov 7, 2023
@kensternberg-authentik
Merge branch 'main' into dev
100a6f0 
* main:
  web: bump @types/chart.js from 2.9.39 to 2.9.40 in /web
  website/integrations: add FreshRSS (#7301)
  web: bump the eslint group in /web with 2 updates
  core: bump uvicorn from 0.24.0 to 0.24.0.post1
  web: bump the storybook group in /web with 5 updates
  web: bump the eslint group in /tests/wdio with 2 updates
  web: bump @types/codemirror from 5.60.12 to 5.60.13 in /web
  web: bump mermaid from 10.6.0 to 10.6.1 in /web
  translate: Updates for file web/xliff/en.xlf in fr (#7461)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7459)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7458)
  web: bump @lit/localize-tools from 0.7.0 to 0.7.1 in /web (#7369)
  web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rissson rissson rissson approved these changes

@tanberry tanberry Awaiting requested review from tanberry

+2 more reviewers

@Alkarex Alkarex Alkarex left review comments

@XtremeOwnageDotCom XtremeOwnageDotCom XtremeOwnageDotCom left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@foux @XtremeOwnageDotCom @Alkarex @rissson