enterprise/providers: Add RAC [AUTH-15] by BeryJu · Pull Request #7291 · goauthentik/authentik

BeryJu · 2023-10-25T15:02:17Z

Details

TODOs:

Audio (from remote machine to client)
Clipboard
implement Endpoint
Terminate connection on session expiry

Better reconnect
VNC tests
property mappings for settings
UI trigger for opening a sidebar
- guacamole uses a keyboard shortcut which works but isn't ideal, however we don't really want to steal any viewport to display a trigger

Things to do later:

File transfer
On-screen keyboard
Better touchscreen support\

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)
The translation files have been updated (make i18n-extract)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

notion-workspace · 2023-10-25T15:02:22Z

RDP/SSH access via authentik

netlify · 2023-10-25T15:02:23Z

✅ Deploy Preview for authentik-storybook canceled.

Name	Link
🔨 Latest commit	`7561c9b`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/658f3e684b2d890008e1e34b

codecov · 2023-10-25T18:24:46Z

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (0e1646c) 92.02% compared to head (7561c9b) 92.30%.

Files	Patch %	Lines
...hentik/enterprise/providers/rac/consumer_client.py	32.05%	53 Missing ⚠️
...entik/enterprise/providers/rac/consumer_outpost.py	47.36%	10 Missing ⚠️
authentik/enterprise/providers/rac/models.py	95.41%	5 Missing ⚠️
authentik/outposts/controllers/kubernetes.py	75.00%	5 Missing ⚠️
authentik/outposts/tasks.py	28.57%	5 Missing ⚠️
...uthentik/enterprise/providers/rac/api/endpoints.py	95.77%	3 Missing ⚠️
.../enterprise/providers/rac/api/property_mappings.py	86.36%	3 Missing ⚠️
...enterprise/providers/rac/controllers/kubernetes.py	62.50%	3 Missing ⚠️
authentik/enterprise/providers/rac/views.py	95.16%	3 Missing ⚠️
authentik/enterprise/policy.py	60.00%	2 Missing ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7291      +/-   ##
==========================================
+ Coverage   92.02%   92.30%   +0.28%     
==========================================
  Files         594      608      +14     
  Lines       29524    30120     +596     
==========================================
+ Hits        27168    27803     +635     
+ Misses       2356     2317      -39

Flag	Coverage Δ
e2e	`50.62% <43.29%> (+1.49%)`	⬆️
integration	`26.25% <31.46%> (+0.07%)`	⬆️
unit	`89.51% <81.46%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

netlify · 2023-10-30T20:34:34Z

✅ Deploy Preview for authentik ready!

Name	Link
🔨 Latest commit	`97d6fc0`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik/deploys/658f3635f82e5c0008f99ba0
😎 Deploy Preview	https://deploy-preview-7291--authentik.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kensternberg-authentik

Of the JavaScript, it all looks very straightforward and standardized, right down to the (by now completely repetitive) getSuccessMessage(). And I'm going to to have to learn more about Guacamole now.

github-actions · 2023-11-24T12:55:44Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-enterprise-provider-rac-1703887684-7561c9b
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-enterprise-provider-rac-1703887684-7561c9b-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-enterprise-provider-rac-1703887684-7561c9b

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-enterprise-provider-rac-1703887684-7561c9b-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* main: (30 commits) outposts/proxy: better Redis error message (#8044) translate: Updates for file web/xliff/en.xlf in fr (#8046) web: bump the eslint group in /tests/wdio with 2 updates (#8041) web: bump the storybook group in /web with 7 updates (#8042) web: bump the eslint group in /web with 2 updates (#8043) web: bump @types/guacamole-common-js from 1.3.2 to 1.5.2 in /web (#8030) translate: Updates for file web/xliff/en.xlf in zh_CN (#8038) translate: Updates for file web/xliff/en.xlf in zh-Hans (#8039) website: bump clsx from 2.0.0 to 2.1.0 in /website (#8033) core: bump golang from 1.21.3-bookworm to 1.21.5-bookworm (#8027) web: bump the babel group in /web with 4 updates (#8028) web: bump the esbuild group in /web with 2 updates (#8029) web: bump rollup from 4.9.1 to 4.9.2 in /web (#8031) tests/e2e: fix tests to work without docker network_mode host (#8035) website/docs: fix typo (#8015) web: bump API Client version (#8025) enterprise/providers: Add RAC [AUTH-15] (#7291) outposts: disable deployment and secret reconciler for embedded outpost in code instead of in config (#8021) providers/proxy: use access token (#8022) website/integrations: Add custom Group/Role mapping documentation for Grafana (#7453) ...

BeryJu requested review from a team as code owners October 25, 2023 15:02

BeryJu force-pushed the enterprise/provider/rac branch 2 times, most recently from 87bdf2b to d900ae2 Compare October 30, 2023 20:32

kensternberg-authentik approved these changes Nov 6, 2023

View reviewed changes

BeryJu force-pushed the enterprise/provider/rac branch from cea2a09 to 791d356 Compare November 6, 2023 22:37

BeryJu added the deploy_me Deploy the PR changes on a test environment label Nov 6, 2023

BeryJu force-pushed the enterprise/provider/rac branch 3 times, most recently from 07c99cb to 4d1a850 Compare November 14, 2023 13:17

BeryJu force-pushed the enterprise/provider/rac branch from b82ba80 to 18f31b6 Compare November 16, 2023 10:51

BeryJu force-pushed the enterprise/provider/rac branch 4 times, most recently from dba0f73 to 05bcdf2 Compare November 23, 2023 23:35

BeryJu force-pushed the enterprise/provider/rac branch from 37d08ad to 38defea Compare December 3, 2023 22:06

BeryJu force-pushed the enterprise/provider/rac branch 8 times, most recently from 9a0742a to 92acec9 Compare December 27, 2023 16:59

BeryJu added 25 commits December 29, 2023 22:12

support host:port and fix protocol

67324e1

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

center smaller viewport

6259836

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

rework connection to wait more and stop after some time

16d5271

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add policy control to endpoints

50c6e1c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

remove provider protocol

f1398ce

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

don't switch to different outpost connection when already chosen

4658e0c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

start using property mappings, add static settings

2299575

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add some RAC mapping settings

432a05a

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix lint

a4ef0b9

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

start adding tests

81ccc3a

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add tests for event changes

b26e54c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add tests and fix issues found by said tests

de38a95

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add preview banner, move endpoints to main page

fcdf2aa

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add locale

bfc9311

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

auto-select endpoint if only one is available

952dafd

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

backport #7831 to rac

ae2e8ca

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

dont select property mappings on endpoints

8188ca2

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

make table modal only load when opened

d556825

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

only auto-redirect when open

93ef138

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix web deps

c2bd19b

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

check for token expiry and terminate session

ddc9687

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

re-add endpoint name to title

5309f02

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

disconnect connection when token is manually deleted

4546bac

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add initial RAC docs

4bef6bd

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add connection expiry setting to provider

97d6fc0

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu force-pushed the enterprise/provider/rac branch from 6842bc9 to 97d6fc0 Compare December 29, 2023 21:12

fix flaky tests

7561c9b

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu merged commit 240cf6d into main Dec 30, 2023

BeryJu deleted the enterprise/provider/rac branch December 30, 2023 20:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

enterprise/providers: Add RAC [AUTH-15]#7291

enterprise/providers: Add RAC [AUTH-15]#7291
BeryJu merged 72 commits intomainfrom
enterprise/provider/rac

BeryJu commented Oct 25, 2023 •

edited

Loading

Uh oh!

notion-workspace bot commented Oct 25, 2023

Uh oh!

netlify bot commented Oct 25, 2023 •

edited

Loading

Uh oh!

codecov bot commented Oct 25, 2023 •

edited

Loading

Uh oh!

netlify bot commented Oct 30, 2023 •

edited

Loading

Uh oh!

kensternberg-authentik left a comment

Uh oh!

github-actions bot commented Nov 24, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BeryJu commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Checklist

Uh oh!

notion-workspace bot commented Oct 25, 2023

Uh oh!

netlify bot commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook canceled.

Uh oh!

codecov bot commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

netlify bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik ready!

Uh oh!

kensternberg-authentik left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BeryJu commented Oct 25, 2023 •

edited

Loading

netlify bot commented Oct 25, 2023 •

edited

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading

netlify bot commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Nov 24, 2023 •

edited

Loading