Skip to content

core: Use branding_title in the end session page#7282

Merged
BeryJu merged 1 commit intogoauthentik:mainfrom
duhast:patch-2
Oct 25, 2023
Merged

core: Use branding_title in the end session page#7282
BeryJu merged 1 commit intogoauthentik:mainfrom
duhast:patch-2

Conversation

@duhast
Copy link
Contributor

@duhast duhast commented Oct 25, 2023

Details

Use branding_title in the end session "You've logged out of" section.

Currently there is one place that shows "authentik" instead of tenant name:
image


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Use branding_title in the end session "You've logged out of" section

Signed-off-by: Oleh Vivtash <oleh@vivtash.net>
@duhast duhast requested a review from a team as a code owner October 25, 2023 00:10
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 439ff0d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65385ce7206c5d0008d84d4b

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa954c4) 92.54% compared to head (439ff0d) 92.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7282      +/-   ##
==========================================
+ Coverage   92.54%   92.63%   +0.08%     
==========================================
  Files         587      587              
  Lines       28876    28876              
==========================================
+ Hits        26724    26749      +25     
+ Misses       2152     2127      -25     
Flag Coverage Δ
e2e 50.91% <ø> (+0.67%) ⬆️
integration 26.01% <ø> (ø)
unit 89.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duhast duhast changed the title Update end_session.html Use branding_title in the end session page Oct 25, 2023
@BeryJu BeryJu changed the title Use branding_title in the end session page core: Use branding_title in the end session page Oct 25, 2023
@BeryJu BeryJu merged commit add873c into goauthentik:main Oct 25, 2023
kensternberg-authentik added a commit that referenced this pull request Oct 25, 2023
* main: (28 commits)
  web: fix typo in traefik name
  web/admin: disable wizard banner for now (#7294)
  web/admin: small fixes (#7292)
  core: Use branding_title in the end session page (#7282)
  web: bump pyright from 1.1.332 to 1.1.333 in /web (#7287)
  website: bump react-tooltip from 5.21.5 to 5.21.6 in /website (#7283)
  web: bump the sentry group in /web with 2 updates (#7285)
  web: bump the eslint group in /web with 1 update (#7286)
  core: bump ruff from 0.1.1 to 0.1.2 (#7289)
  core: bump pytest from 7.4.2 to 7.4.3 (#7288)
  web: bump the wdio group in /tests/wdio with 3 updates (#7290)
  website/blogs: fixed typo in blog (#7281)
  core: bump pylint from 2.17.7 to 3.0.2 (#7270)
  web: bump the eslint group in /tests/wdio with 2 updates (#7274)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7278)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7277)
  ci: bump actions/setup-node from 3 to 4 (#7268)
  core: bump pylint-django from 2.5.4 to 2.5.5 (#7271)
  web: bump the eslint group in /web with 2 updates (#7269)
  web: bump @trivago/prettier-plugin-sort-imports from 4.2.0 to 4.2.1 in /tests/wdio (#7275)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants