sources/ldap: add check command to verify ldap connectivity by BeryJu · Pull Request #7263 · goauthentik/authentik

BeryJu · 2023-10-23T20:37:32Z

Details

Also Show the connectivity to LDAP servers in the webui, and slightly refactor sync status

also #6816

Checklist

Local tests pass (ak test authentik/)
The code has been formatted (make lint-fix)

If an API change has been made

The API schema has been updated (make gen-build)

If changes to the frontend have been made

The code has been formatted (make web)
The translation files have been updated (make i18n-extract)

If applicable

The documentation has been updated
The documentation has been formatted (make website)

netlify · 2023-10-23T20:37:37Z

✅ Deploy Preview for authentik-storybook ready!

Name	Link
🔨 Latest commit	`7dc3127`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik-storybook/deploys/6552275cf0c0a10008e8429d
😎 Deploy Preview	https://deploy-preview-7263--authentik-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-10-23T20:38:54Z

✅ Deploy Preview for authentik ready!

Name	Link
🔨 Latest commit	`17b73f4`
🔍 Latest deploy log	https://app.netlify.com/sites/authentik/deploys/6536f09fc4e8f700071f1cf7
😎 Deploy Preview	https://deploy-preview-7263--authentik.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 20 from production) Accessibility: 90 (no change from production) Best Practices: 100 (no change from production) SEO: 80 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2023-10-23T20:51:52Z

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e3ac774) 92.61% compared to head (04263c9) 90.12%.
Report is 186 commits behind head on main.

❗ Current head 04263c9 differs from pull request most recent head 7dc3127. Consider uploading reports for the commit 7dc3127 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7263      +/-   ##
==========================================
- Coverage   92.61%   90.12%   -2.50%     
==========================================
  Files         587      587              
  Lines       28852    29029     +177     
==========================================
- Hits        26721    26161     -560     
- Misses       2131     2868     +737

Flag	Coverage Δ
e2e	`46.07% <48.61%> (-4.89%)`	⬇️
integration	`?`
unit	`89.67% <84.72%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
authentik/sources/ldap/settings.py	`100.00% <ø> (ø)`
authentik/sources/ldap/signals.py	`67.92% <100.00%> (+0.61%)`	⬆️
authentik/sources/ldap/sync/groups.py	`86.36% <100.00%> (ø)`
authentik/sources/ldap/sync/users.py	`88.88% <100.00%> (ø)`
authentik/sources/ldap/sync/vendor/freeipa.py	`72.72% <100.00%> (ø)`
authentik/sources/ldap/tasks.py	`89.65% <100.00%> (+1.81%)`	⬆️
authentik/sources/ldap/sync/base.py	`93.69% <87.50%> (ø)`
authentik/sources/ldap/api.py	`80.00% <66.66%> (+3.75%)`	⬆️
authentik/sources/ldap/models.py	`77.27% <79.16%> (-0.21%)`	⬇️

... and 77 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

github-actions · 2023-10-23T22:41:49Z

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-check-connectivity-1698100334-17b73f4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-check-connectivity-1698100334-17b73f4-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-check-connectivity-1698100334-17b73f4

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-check-connectivity-1698100334-17b73f4-arm64

Afterwards, run the upgrade commands from the latest release notes.

authentik/sources/ldap/management/commands/ldap_check_connection.py

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

authentik/sources/ldap/models.py

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

terion-name · 2023-11-13T14:16:42Z

In this particular moment we are struggling with related issues and searching solutions =) In what release this will be added?

BeryJu · 2023-11-13T14:24:51Z

In this particular moment we are struggling with related issues and searching solutions =) In what release this will be added?

2024.1 most likely, or you can use the beta

terion-name · 2023-11-13T14:25:29Z

In this particular moment we are struggling with related issues and searching solutions =) In what release this will be added?

2024.1 most likely, or you can use the beta

How to use beta? Don't see it in containers

BeryJu · 2023-11-13T14:29:37Z

https://goauthentik.io/docs/installation/beta

terion-name · 2023-11-14T14:11:35Z

Did not resolve #6816 =(

* main: (24 commits) internal: remove special route for /outpost.goauthentik.io (#7539) providers/proxy: Fix duplicate cookies when using file system store. (#7541) web: bump API Client version (#7543) sources/ldap: add check command to verify ldap connectivity (#7263) internal: remove deprecated metrics (#7540) core: compile backend translations (#7538) web: bump prettier from 3.0.3 to 3.1.0 in /web (#7528) web: bump @trivago/prettier-plugin-sort-imports from 4.2.1 to 4.3.0 in /web (#7531) web: bump rollup from 4.3.0 to 4.4.0 in /web (#7529) core: bump celery from 5.3.4 to 5.3.5 (#7536) web: bump @formatjs/intl-listformat from 7.5.1 to 7.5.2 in /web (#7530) web: bump prettier from 3.0.3 to 3.1.0 in /tests/wdio (#7532) web: bump @trivago/prettier-plugin-sort-imports from 4.2.1 to 4.3.0 in /tests/wdio (#7533) website: bump prettier from 3.0.3 to 3.1.0 in /website (#7534) website: bump prism-react-renderer from 2.1.0 to 2.2.0 in /website (#7535) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7537) root: Restructure broker / cache / channel / result configuration (#7097) core: bump twilio from 8.10.0 to 8.10.1 (#7474) web: bump axios from 1.5.0 to 1.6.1 in /web (#7518) web: bump wdio-wait-for from 3.0.7 to 3.0.8 in /tests/wdio (#7514) ...

notion-workspace · 2024-02-07T16:06:22Z

Show better log in LDAP Source status when sync fails

BeryJu requested review from a team as code owners October 23, 2023 20:37

sources/ldap: add check command to verify ldap connectivity

17b73f4

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu force-pushed the sources/ldap/check-connectivity branch from 9fa3a4f to 17b73f4 Compare October 23, 2023 22:15

rissson reviewed Oct 24, 2023

View reviewed changes

authentik/sources/ldap/management/commands/ldap_check_connection.py Outdated Show resolved Hide resolved

BeryJu changed the base branch from main to version-2023.8 October 25, 2023 13:44

BeryJu requested a review from a team as a code owner October 25, 2023 13:44

BeryJu requested review from smilelyj and removed request for a team October 25, 2023 13:44

BeryJu changed the base branch from version-2023.8 to main October 25, 2023 13:45

BeryJu added 3 commits November 12, 2023 18:57

default to checking all sources

61a642c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

start adding an API for ldap connectivity

da01e33

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

add webui for ldap source connection status

8318c9c

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu requested a review from a team as a code owner November 12, 2023 20:18

better show sync status, clear previous tasks

9cd58f1

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

rissson reviewed Nov 13, 2023

View reviewed changes

authentik/sources/ldap/models.py Outdated Show resolved Hide resolved

BeryJu added 3 commits November 13, 2023 13:52

set timeout on redis lock for ldap sync

04263c9

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix py lint

3be9a3f

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

fix web lint

7dc3127

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

BeryJu merged commit f728bbb into main Nov 13, 2023

BeryJu deleted the sources/ldap/check-connectivity branch November 13, 2023 14:01

terion-name mentioned this pull request Nov 14, 2023

ldap_sync for many users is spamming the System Tasks #6816

Open

BeryJu mentioned this pull request Apr 11, 2024

LDAP Federation Logs #3880

Closed

BeryJu mentioned this pull request Jul 18, 2024

Don't schedule an LDAP sync (ldap_sync_all) while it's still running #6810

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

sources/ldap: add check command to verify ldap connectivity#7263

sources/ldap: add check command to verify ldap connectivity#7263
BeryJu merged 8 commits intomainfrom
sources/ldap/check-connectivity

BeryJu commented Oct 23, 2023 •

edited

Loading

Uh oh!

netlify bot commented Oct 23, 2023 •

edited

Loading

Uh oh!

netlify bot commented Oct 23, 2023 •

edited

Loading

Uh oh!

codecov bot commented Oct 23, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Oct 23, 2023

Uh oh!

Uh oh!

Uh oh!

terion-name commented Nov 13, 2023

Uh oh!

BeryJu commented Nov 13, 2023

Uh oh!

terion-name commented Nov 13, 2023

Uh oh!

BeryJu commented Nov 13, 2023

Uh oh!

terion-name commented Nov 14, 2023

Uh oh!

notion-workspace bot commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

BeryJu commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Checklist

Uh oh!

netlify bot commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik-storybook ready!

Uh oh!

netlify bot commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for authentik ready!

Uh oh!

codecov bot commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 23, 2023

Uh oh!

Uh oh!

Uh oh!

terion-name commented Nov 13, 2023

Uh oh!

BeryJu commented Nov 13, 2023

Uh oh!

terion-name commented Nov 13, 2023

Uh oh!

BeryJu commented Nov 13, 2023

Uh oh!

terion-name commented Nov 14, 2023

Uh oh!

notion-workspace bot commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BeryJu commented Oct 23, 2023 •

edited

Loading

netlify bot commented Oct 23, 2023 •

edited

Loading

netlify bot commented Oct 23, 2023 •

edited

Loading

codecov bot commented Oct 23, 2023 •

edited

Loading