Skip to content

sources/oauth: fix name clash#7253

Merged
BeryJu merged 1 commit intomainfrom
sources/oauth/fix-name-clash
Oct 21, 2023
Merged

sources/oauth: fix name clash#7253
BeryJu merged 1 commit intomainfrom
sources/oauth/fix-name-clash

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 21, 2023

Details

closes #7096


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner October 21, 2023 14:28
@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 4b7396c
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6533e01574bc170008a1320a

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (52a4524) 92.61% compared to head (4b7396c) 92.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7253   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files         587      587           
  Lines       28852    28852           
=======================================
  Hits        26720    26720           
  Misses       2132     2132           
Flag Coverage Δ
e2e 50.96% <78.26%> (ø)
integration 26.03% <13.04%> (ø)
unit 89.63% <52.17%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentik/sources/oauth/clients/base.py 92.59% <100.00%> (ø)
authentik/sources/oauth/clients/oauth1.py 87.09% <100.00%> (ø)
authentik/sources/oauth/clients/oauth2.py 81.44% <100.00%> (ø)
authentik/sources/oauth/models.py 100.00% <100.00%> (ø)
authentik/sources/oauth/types/github.py 90.69% <100.00%> (ø)
authentik/sources/oauth/views/base.py 100.00% <100.00%> (ø)
authentik/sources/oauth/api/source.py 81.55% <0.00%> (ø)
authentik/sources/oauth/types/mailcow.py 68.75% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-oauth-fix-name-clash-1697900595-4b7396c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-oauth-fix-name-clash-1697900595-4b7396c-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-oauth-fix-name-clash-1697900595-4b7396c

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-oauth-fix-name-clash-1697900595-4b7396c-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 616f0b8 into main Oct 21, 2023
@BeryJu BeryJu deleted the sources/oauth/fix-name-clash branch October 21, 2023 18:29
kensternberg-authentik added a commit that referenced this pull request Oct 23, 2023
* main:
  core: bump pylint-django from 2.5.3 to 2.5.4 (#7255)
  core: bump goauthentik.io/api/v3 from 3.2023083.9 to 3.2023083.10 (#7256)
  web: bump the wdio group in /tests/wdio with 1 update (#7258)
  web: bump the eslint group in /tests/wdio with 1 update (#7257)
  sources/oauth: fix name clash (#7253)
  web: bump the eslint group in /web with 1 update (#7250)
  web: bump mermaid from 10.5.0 to 10.5.1 in /web (#7247)
  web: break circular dependency between AKElement & Interface. (#7165)
PKizzle added a commit to PKizzle/authentik that referenced this pull request Oct 27, 2023
PKizzle added a commit to PKizzle/authentik that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename type attribute in the model

1 participant