web: change 'Attributes' to 'Custom attributes' on Invitation Field#7145
Merged
kensternberg-authentik merged 2 commits intomainfrom Oct 12, 2023
Merged
web: change 'Attributes' to 'Custom attributes' on Invitation Field#7145kensternberg-authentik merged 2 commits intomainfrom
kensternberg-authentik merged 2 commits intomainfrom
Conversation
Everywhere else, the label "Attributes" refers to the dictionary field that our core models have and use as a JSON repository for key/value pairs that don't need the full model's awareness or management. Using the same label here, where the term refers to the context data of the invitation itself, may confuse people, so we've changed the label to signal its difference.
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7145 +/- ##
==========================================
+ Coverage 92.55% 92.67% +0.13%
==========================================
Files 568 568
Lines 28049 28049
==========================================
+ Hits 25957 25992 +35
+ Misses 2092 2057 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-change-label-on-invitation-form-1697135627-57f4f1e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-web-change-label-on-invitation-form-1697135627-57f4f1e-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-web-change-label-on-invitation-form-1697135627-57f4f1eFor arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-web-change-label-on-invitation-form-1697135627-57f4f1e-arm64Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
approved these changes
Oct 12, 2023
* main: web: patternfly hints as ak-web-component (#7120) web: fix form default submit handler (#7122) web/admin: add additional Flow info (#7155) tests: fix potential infinite wait in tests spinning up a container (#7153) ci: disable ghcr retention schedule while it's broken (#7154) translate: Updates for file locale/en/LC_MESSAGES/django.po in de (#7151) core: bump golang.org/x/net from 0.16.0 to 0.17.0 (#7148) web: bump the babel group in /web with 5 updates (#7149) core: bump sentry-sdk from 1.31.0 to 1.32.0 (#7150) website: make get started on pricing page go to customer portal (#7147)
kensternberg-authentik
added a commit
that referenced
this pull request
Oct 13, 2023
* main: web: change 'Attributes' to 'Custom attributes' on Invitation Field (#7145)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Everywhere else, the label "Attributes" refers to the dictionary field that our core models have and use as a JSON repository for key/value pairs that don't need the full model's awareness or management. Using the same label here, where the term refers to the context data of the invitation itself, may confuse people, so we've changed the label to signal its difference.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)