Skip to content

stage/deny: add custom message#7144

Merged
BeryJu merged 3 commits intomainfrom
smusali/5752-new
Oct 18, 2023
Merged

stage/deny: add custom message#7144
BeryJu merged 3 commits intomainfrom
smusali/5752-new

Conversation

@smusali
Copy link
Contributor

@smusali smusali commented Oct 11, 2023

Details

This PR handles #5752


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@smusali smusali added enhancement New feature or request python enhancement/confirmed Enhancements that will be implemented in the future labels Oct 11, 2023
@smusali smusali requested a review from a team as a code owner October 11, 2023 15:19
@smusali smusali self-assigned this Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit cc3a794
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/652fa548734fb50008c8b495
😎 Deploy Preview https://deploy-preview-7144--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@notion-workspace
Copy link

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit cc3a794
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/652fa548f219b2000815567a
😎 Deploy Preview https://deploy-preview-7144--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (no change from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c7182bf) 43.95% compared to head (cc3a794) 90.56%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7144       +/-   ##
===========================================
+ Coverage   43.95%   90.56%   +46.61%     
===========================================
  Files         584      584               
  Lines       28680    28704       +24     
===========================================
+ Hits        12606    25997    +13391     
+ Misses      16074     2707    -13367     
Flag Coverage Δ
e2e 48.15% <15.38%> (+4.19%) ⬆️
unit 89.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentik/stages/deny/api.py 100.00% <100.00%> (ø)
authentik/stages/deny/models.py 100.00% <100.00%> (+15.78%) ⬆️
authentik/stages/deny/stage.py 100.00% <100.00%> (+20.00%) ⬆️
authentik/stages/deny/tests.py 100.00% <100.00%> (+100.00%) ⬆️

... and 423 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smusali smusali force-pushed the smusali/5752-new branch 2 times, most recently from 040108e to 3f9c003 Compare October 17, 2023 22:39
Samir Musali and others added 3 commits October 18, 2023 11:22
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners October 18, 2023 09:28
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-smusali-5752-new-1697622203-cc3a794
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-smusali-5752-new-1697622203-cc3a794-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-smusali-5752-new-1697622203-cc3a794

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-smusali-5752-new-1697622203-cc3a794-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit a60f3b4 into main Oct 18, 2023
@BeryJu BeryJu deleted the smusali/5752-new branch October 18, 2023 15:13
kensternberg-authentik added a commit that referenced this pull request Oct 19, 2023
* main: (57 commits)
  stages/email: Fix query parameters getting lost in Email links (#5376)
  core/rbac: fix missing field when removing perm, add delete from object page (#7226)
  website/integrations: grafana: add Helm and Terraform config examples (#7121)
  web: bump @types/codemirror from 5.60.11 to 5.60.12 in /web (#7223)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7224)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7225)
  website/blogs: blog about sso tax (#7202)
  web: Application wizard v2 with tests (#7004)
  web: bump API Client version (#7220)
  core: bump goauthentik.io/api/v3 from 3.2023083.7 to 3.2023083.8 (#7221)
  providers/radius: TOTP MFA support (#7217)
  web: bump API Client version (#7218)
  stage/deny: add custom message (#7144)
  docs: update full-dev-setup docs (#7205)
  enterprise: bump license usage task frequency (#7215)
  web: bump the storybook group in /web with 5 updates (#7212)
  web: bump the sentry group in /web with 2 updates (#7211)
  Revert "web: Updates to the Context and Tasks libraries from lit. (#7168)"
  web: bump @types/codemirror from 5.60.10 to 5.60.11 in /web (#7209)
  web: bump @types/chart.js from 2.9.38 to 2.9.39 in /web (#7206)
  ...
kensternberg-authentik added a commit that referenced this pull request Oct 19, 2023
* main: (119 commits)
  stages/email: Fix query parameters getting lost in Email links (#5376)
  core/rbac: fix missing field when removing perm, add delete from object page (#7226)
  website/integrations: grafana: add Helm and Terraform config examples (#7121)
  web: bump @types/codemirror from 5.60.11 to 5.60.12 in /web (#7223)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7224)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7225)
  website/blogs: blog about sso tax (#7202)
  web: Application wizard v2 with tests (#7004)
  web: bump API Client version (#7220)
  core: bump goauthentik.io/api/v3 from 3.2023083.7 to 3.2023083.8 (#7221)
  providers/radius: TOTP MFA support (#7217)
  web: bump API Client version (#7218)
  stage/deny: add custom message (#7144)
  docs: update full-dev-setup docs (#7205)
  enterprise: bump license usage task frequency (#7215)
  web: bump the storybook group in /web with 5 updates (#7212)
  web: bump the sentry group in /web with 2 updates (#7211)
  Revert "web: Updates to the Context and Tasks libraries from lit. (#7168)"
  web: bump @types/codemirror from 5.60.10 to 5.60.11 in /web (#7209)
  web: bump @types/chart.js from 2.9.38 to 2.9.39 in /web (#7206)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants