Skip to content

providers/proxy: fix redis cookies missing strict path#7135

Merged
BeryJu merged 1 commit intomainfrom
providers/proxy/fix-redis-cookie-path
Oct 10, 2023
Merged

providers/proxy: fix redis cookies missing strict path#7135
BeryJu merged 1 commit intomainfrom
providers/proxy/fix-redis-cookie-path

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 10, 2023

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner October 10, 2023 10:01
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit de3af7e
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/652520e79f92ab000817f06a

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f07a1ed) 91.15% compared to head (de3af7e) 92.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7135      +/-   ##
==========================================
+ Coverage   91.15%   92.67%   +1.52%     
==========================================
  Files         568      568              
  Lines       28049    28049              
==========================================
+ Hits        25566    25992     +426     
+ Misses       2483     2057     -426     
Flag Coverage Δ
e2e 51.19% <ø> (+0.02%) ⬆️
integration 26.34% <ø> (?)
unit 89.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit dd7d3bf into main Oct 10, 2023
@BeryJu BeryJu deleted the providers/proxy/fix-redis-cookie-path branch October 10, 2023 10:17
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-proxy-fix-redis-cookie-path-1696932851-de3af7e
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-proxy-fix-redis-cookie-path-1696932851-de3af7e-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-proxy-fix-redis-cookie-path-1696932851-de3af7e

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-proxy-fix-redis-cookie-path-1696932851-de3af7e-arm64

Afterwards, run the upgrade commands from the latest release notes.

kensternberg-authentik added a commit that referenced this pull request Oct 11, 2023
* main:
  web: bump pyright from 1.1.330 to 1.1.331 in /web (#7143)
  core: bump golang from 1.21.2-bookworm to 1.21.3-bookworm (#7142)
  core: bump gitpython from 3.1.35 to 3.1.37 (#7140)
  core: bump goauthentik.io/api/v3 from 3.2023083.5 to 3.2023083.6 (#7124)
  website/docs: fix PowerDNS Docker Hub repo name (#7134)
  website/blog: Fix typo in SCIM post (#7136)
  providers/proxy: fix redis cookies missing strict path (#7135)
  web: bump @lit-labs/task from 3.0.2 to 3.1.0 in /web (#7132)
  web: bump @lit/localize-tools from 0.6.10 to 0.7.0 in /web (#7133)
  web: bump the eslint group in /tests/wdio with 2 updates (#7128)
  core: bump structlog from 23.1.0 to 23.2.0 (#7125)
  core: bump selenium from 4.13.0 to 4.14.0 (#7126)
  web: bump the eslint group in /web with 2 updates (#7127)
  web: bump the wdio group in /tests/wdio with 4 updates (#7129)
kensternberg-authentik added a commit that referenced this pull request Oct 12, 2023
* main:
  web: bump pyright from 1.1.330 to 1.1.331 in /web (#7143)
  core: bump golang from 1.21.2-bookworm to 1.21.3-bookworm (#7142)
  core: bump gitpython from 3.1.35 to 3.1.37 (#7140)
  core: bump goauthentik.io/api/v3 from 3.2023083.5 to 3.2023083.6 (#7124)
  website/docs: fix PowerDNS Docker Hub repo name (#7134)
  website/blog: Fix typo in SCIM post (#7136)
  providers/proxy: fix redis cookies missing strict path (#7135)
  web: bump @lit-labs/task from 3.0.2 to 3.1.0 in /web (#7132)
  web: bump @lit/localize-tools from 0.6.10 to 0.7.0 in /web (#7133)
  web: bump the eslint group in /tests/wdio with 2 updates (#7128)
  core: bump structlog from 23.1.0 to 23.2.0 (#7125)
  core: bump selenium from 4.13.0 to 4.14.0 (#7126)
  web: bump the eslint group in /web with 2 updates (#7127)
  web: bump the wdio group in /tests/wdio with 4 updates (#7129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant