Skip to content

sources/ldap: add default property mapping to mirror directory structure#6990

Merged
BeryJu merged 3 commits intomainfrom
sources/ldap/mirror-directory-structure
Sep 26, 2023
Merged

sources/ldap: add default property mapping to mirror directory structure#6990
BeryJu merged 3 commits intomainfrom
sources/ldap/mirror-directory-structure

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Sep 26, 2023

Details

Mirror LDAP structure into authentik user path


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner September 26, 2023 12:28
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ee3ef75
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65130cfc41c586000893b439

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0e59526) 92.71% compared to head (04e97f2) 91.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6990      +/-   ##
==========================================
- Coverage   92.71%   91.19%   -1.51%     
==========================================
  Files         567      567              
  Lines       27959    27960       +1     
==========================================
- Hits        25920    25496     -424     
- Misses       2039     2464     +425     
Flag Coverage Δ
e2e 51.11% <66.67%> (-<0.01%) ⬇️
integration ?
unit 89.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentik/sources/ldap/sync/base.py 93.70% <100.00%> (ø)
authentik/sources/ldap/tests/mock_ad.py 100.00% <ø> (ø)
authentik/sources/ldap/tests/test_sync.py 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-mirror-directory-structure-1695748054-ee3ef75
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-mirror-directory-structure-1695748054-ee3ef75-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-mirror-directory-structure-1695748054-ee3ef75

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-mirror-directory-structure-1695748054-ee3ef75-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 90aa540 into main Sep 26, 2023
@BeryJu BeryJu deleted the sources/ldap/mirror-directory-structure branch September 26, 2023 16:55
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit ee3ef75
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65130cfc550525000831b9c6
😎 Deploy Preview https://deploy-preview-6990--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 8 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

kensternberg-authentik added a commit that referenced this pull request Sep 27, 2023
* main: (41 commits)
  root: fix missing /lifecycle in path
  website/blog: add info-block to blog about m2m (#7002)
  root: handle SIGHUP and SIGUSR2, healthcheck gunicorn (#6630)
  flows: stage_invalid() makes flow restart depending on invalid_response_action setting (#6780)
  core: bump psycopg from 3.1.11 to 3.1.12 (#6997)
  core: bump pydantic from 2.4.0 to 2.4.1 (#6998)
  web: bump the sentry group in /web with 2 updates (#6999)
  web: bump pyright from 1.1.328 to 1.1.329 in /web (#7000)
  website/blog: improved sentence (#6995)
  website/blog: fix missing link in m2m post (#6994)
  web/user: fix incorrect link to admin interface (#6993)
  root: disable APPEND_SLASH (#6928)
  root: replace boj/redistore with vendored version of rbcervilla/redisstore (#6988)
  sources/ldap: add default property mapping to mirror directory structure (#6990)
  website/blogs: Blog about m2m (#6974)
  root: make Celery worker concurrency configurable (#6837)
  root: make postgres connection in makefile customizable (#6977)
  core: prevent self-impersonation (#6885)
  web: bump @typescript-eslint/parser from 6.7.2 to 6.7.3 in /web (#6984)
  core: bump pydantic from 2.3.0 to 2.4.0 (#6979)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant