providers/proxy: set outpost session cookie to httponly and secure wh…#6482
Merged
providers/proxy: set outpost session cookie to httponly and secure wh…#6482
Conversation
…en possible Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook canceled.
|
rissson
approved these changes
Aug 5, 2023
Member
|
Maybe set samesite as well? |
Member
Author
I just talked about that on discord too, SameSite could on theory break some SSO stuff, which is why the main server also sets it to Lax (allthough I think those issues only occurred with SAML) |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #6482 +/- ##
==========================================
- Coverage 92.48% 92.45% -0.02%
==========================================
Files 561 561
Lines 27080 27080
==========================================
- Hits 25041 25035 -6
- Misses 2039 2045 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-proxy-http-only-1691264971-6e5e7cf
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-proxy-http-only-1691264971-6e5e7cf-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-providers-proxy-http-only-1691264971-6e5e7cfFor arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-providers-proxy-http-only-1691264971-6e5e7cf-arm64Afterwards, run the upgrade commands from the latest release notes. |
BeryJu
added a commit
that referenced
this pull request
Aug 7, 2023
#6482) * providers/proxy: set outpost session cookie to httponly and secure when possible Signed-off-by: Jens Langhammer <jens@goauthentik.io> * set samesite too Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Aug 7, 2023
* main: web/flows: fix identification stage band color (#6489) providers/proxy: only intercept auth header when a value is set (#6488) web: bump @goauthentik/api from 2023.6.1-1691242648 to 2023.6.1-1691266058 in /web (#6486) providers/proxy: set outpost session cookie to httponly and secure wh… (#6482) web: bump @esbuild/linux-arm64 from 0.18.17 to 0.18.18 in /web (#6483) web/admin: fix user sorting by active field (#6485) web: bump @esbuild/darwin-arm64 from 0.18.17 to 0.18.18 in /web (#6484) web: bump storybook (#6481) web: bump the sentry group in /web with 2 updates (#6480) web: bump API Client version (#6479) api: optimise pagination in API schema (#6478) website/dev-docs: tweaks to template (#6474) website: bump react-tooltip from 5.19.0 to 5.20.0 in /website (#6471) website: bump prettier from 3.0.0 to 3.0.1 in /website (#6472)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…en possible
Details
security improvement, possible issues when a provider has an external URL configured with HTTPS but is being accessed via HTTP, but that's not supported anyways
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)